schedule: add options to disable replica checker features #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why need to do this change? |
|
@nolouch In some scenarios, we need PD to handle specific types of tasks as quickly as possible. These options allow us to control the process meticulously, rather than let PD decide what to do. |
nolouch
reviewed
Jul 6, 2018
server/schedule/replica_checker.go
Outdated
| @@ -172,6 +176,10 @@ func (r *ReplicaChecker) checkDownPeer(region *core.RegionInfo) *Operator { | |||
| } | |||
|
|
|||
| func (r *ReplicaChecker) checkOfflinePeer(region *core.RegionInfo) *Operator { | |||
| if !r.cluster.IsMakeUpOfflineReplicaEnabled() { | |||
There was a problem hiding this comment.
Seems makeup in here not very suitable. maybe check or replace?
|
PTAL @nolouch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (required)
Add 5 new options to turn on/off features of replicaChecker:
What are the type of the changes (required)?
How has this PR been tested (required)?
Does this PR affect documentation (docs/docs-cn) update? (optional)
pingcap/docs-cn#796
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)