Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: add option to disable namespace checker #1201

Merged

Conversation

nanne007
Copy link
Contributor

@nanne007 nanne007 commented Aug 16, 2018

What have you changed? (required)

This PR add an option to disable namespace checker's region relocation scheduling.

  • disable-namespace-relocation

The implementation uses #1140 for reference.

What are the type of the changes (required)?

  • New feature (non-breaking change which adds functionality)

How has this PR been tested (required)?

make dev and manual test.

Does this PR affect documentation (docs/docs-cn) update? (optional)

TODO: add later

Refer to a related PR or issue link (optional)

#1199

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@sre-bot
Copy link
Contributor

sre-bot commented Aug 16, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@disksing
Copy link
Contributor

/ok-to-test

@disksing
Copy link
Contributor

disksing commented Aug 16, 2018

@lerencao Thanks for your contribution! If it is convenient, could you help me add the document? The related documents are located here: https://github.com/pingcap/docs/blob/master/tools/pd-control.md and https://github.com/pingcap/docs-cn/blob/master/tools/pd-control.md

@nanne007
Copy link
Contributor Author

@disksing Yes, I'm doing it. :)

@nanne007
Copy link
Contributor Author

PR on docs: pingcap/docs-cn#840 and pingcap/docs#573

@disksing
Copy link
Contributor

@lerencao Awesome!

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@disksing disksing merged commit a2cf96b into tikv:master Aug 16, 2018
@nanne007 nanne007 deleted the feature/support-disable-namespace-checker branch August 20, 2018 06:10
@sre-bot sre-bot added the contribution Indicates that the PR was contributed by an external member. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Indicates that the PR was contributed by an external member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants