Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdctl, api: support hex format keys #1309

Merged
merged 5 commits into from
Nov 6, 2018
Merged

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Nov 5, 2018

What problem does this PR solve?

Fix the variety of key formats used in different Ti projects. We finally decided to use the hex format everywhere.

What is changed and how it works?

  • Use hex format as the output of region key related APIs.
  • Support hex format in pdctl and make it the default format.
  • Use hex format keys in logs.

Check List

Tests

  • Integration test

Code changes

  • Has HTTP API interfaces change: The output of region key is changed.

Side effects

  • It breaks backward compatibility for tools that rely on the key format we were using for the region info related APIs.

Related changes

  • Need to update the documentation
  • Need to be included in the release notes

Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2018
@disksing disksing added area/pdctl component/api HTTP API. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 6, 2018
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@disksing disksing merged commit 9ac87dd into tikv:master Nov 6, 2018
@disksing disksing deleted the region-key branch November 6, 2018 10:15
rleungx pushed a commit to rleungx/pd that referenced this pull request Nov 12, 2018
pdctl, api: support hex format keys

Signed-off-by: disksing <i@disksing.com>
nolouch pushed a commit to nolouch/pd that referenced this pull request Jul 10, 2019
pdctl, api: support hex format keys

Signed-off-by: disksing <i@disksing.com>
youjiali1995 pushed a commit that referenced this pull request Jul 17, 2019
* *:Start swithing to the zap logger (#1422)

Signed-off-by: nolouch <nolouch@gmail.com>

* *: log format for schedule, scheduler, syncer, api (#1423)

* log format for schedule, scheduler, syncer, api

Signed-off-by: rleungx <rleungx@gmail.com>

* pdctl, api: support hex format keys (#1309)

pdctl, api: support hex format keys

Signed-off-by: disksing <i@disksing.com>

* *: log format for tools, client, pkg, table (#1424)

* log format for tools, client, pkg, table, simulator

Signed-off-by: rleungx <rleungx@gmail.com>

* *: log format for server (#1431)

* *: log format for server

Signed-off-by: nolouch <nolouch@gmail.com>

* *: log format for logutil, server/core (#1438)

* *: log format for logutil,server/core

* *: improve some logs (#1516)

* improve some logs

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* log: do not add stack to error log (#1532)

* pkg, tools: improve the log message (#1636)

* pkg,tools: improve the log message

Signed-off-by: nolouch <nolouch@gmail.com>

* core: use hex format for region meta key (#1627)

Signed-off-by: Ryan Leung <rleungx@gmail.com>=

* address comments

Signed-off-by: nolouch <nolouch@gmail.com>

* address comments

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/api HTTP API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants