Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg, tools: improve the log message #1636

Merged
merged 3 commits into from
Jul 15, 2019
Merged

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Jul 15, 2019

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Improve the log message.

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

@nolouch nolouch requested review from shafreeck, disksing and rleungx and removed request for disksing July 15, 2019 06:37
@nolouch nolouch added the component/log Log. label Jul 15, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch added the needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. label Jul 15, 2019
Copy link
Contributor

@shafreeck shafreeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/etcdutil/etcdutil.go Outdated Show resolved Hide resolved
@nolouch
Copy link
Contributor Author

nolouch commented Jul 15, 2019

/ok-to-test

@nolouch nolouch merged commit 6d3725d into tikv:master Jul 15, 2019
@nolouch nolouch deleted the fix-log-master branch July 15, 2019 08:10
nolouch added a commit to nolouch/pd that referenced this pull request Jul 15, 2019
* pkg,tools: improve the log message

Signed-off-by: nolouch <nolouch@gmail.com>
nolouch added a commit that referenced this pull request Jul 15, 2019
* pkg,tools: improve the log message

Signed-off-by: nolouch <nolouch@gmail.com>
nolouch added a commit to nolouch/pd that referenced this pull request Jul 15, 2019
* pkg,tools: improve the log message

Signed-off-by: nolouch <nolouch@gmail.com>
youjiali1995 pushed a commit that referenced this pull request Jul 17, 2019
* *:Start swithing to the zap logger (#1422)

Signed-off-by: nolouch <nolouch@gmail.com>

* *: log format for schedule, scheduler, syncer, api (#1423)

* log format for schedule, scheduler, syncer, api

Signed-off-by: rleungx <rleungx@gmail.com>

* pdctl, api: support hex format keys (#1309)

pdctl, api: support hex format keys

Signed-off-by: disksing <i@disksing.com>

* *: log format for tools, client, pkg, table (#1424)

* log format for tools, client, pkg, table, simulator

Signed-off-by: rleungx <rleungx@gmail.com>

* *: log format for server (#1431)

* *: log format for server

Signed-off-by: nolouch <nolouch@gmail.com>

* *: log format for logutil, server/core (#1438)

* *: log format for logutil,server/core

* *: improve some logs (#1516)

* improve some logs

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* log: do not add stack to error log (#1532)

* pkg, tools: improve the log message (#1636)

* pkg,tools: improve the log message

Signed-off-by: nolouch <nolouch@gmail.com>

* core: use hex format for region meta key (#1627)

Signed-off-by: Ryan Leung <rleungx@gmail.com>=

* address comments

Signed-off-by: nolouch <nolouch@gmail.com>

* address comments

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/log Log. needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants