server: update balance score to [0,100]. #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // TODO: we should adjust the weight of used ratio and leader score in futher, | ||
| // now it is a little naive. | ||
| func (cb *capacityBalancer) score(store *storeInfo, regionCount int) float64 { | ||
| usedRatioScore := store.usedRatio() | ||
| leaderScore := store.leaderScore(regionCount) | ||
| score := usedRatioScore*0.6 + leaderScore*0.4 | ||
| score := (usedRatioScore*0.6 + leaderScore*0.4) * 100 |
There was a problem hiding this comment.
I think we should use int for (0, 100), not float64 now.
Btw, (0, 100) means we can't get 0 or 100?
There was a problem hiding this comment.
Actually we may get 0 score, but it is invalid i think.
float64 can be int in our algorithm.
| usedRatioScore := store.usedRatio() | ||
| leaderScore := store.leaderScore(regionCount) | ||
| score := (usedRatioScore*0.6 + leaderScore*0.4) * 100 | ||
| score := int(usedRatioScore*0.6+leaderScore*0.4) * 100 |
There was a problem hiding this comment.
you may always get 0 here.
There was a problem hiding this comment.
So the comment [0,100] is much better?
|
LGTM |
|
@shenli PTAL |
| if regionCount == 0 { | ||
| return 0 | ||
| } | ||
|
|
||
| return float64(s.stats.leaderRegionCount) / float64(regionCount) | ||
| return s.stats.leaderRegionCount / regionCount |
There was a problem hiding this comment.
Yep, missed it.
qiuyesuifeng
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.