Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: fix ticker stop in register #6876

Merged
merged 10 commits into from Aug 3, 2023
Merged

mcs: fix ticker stop in register #6876

merged 10 commits into from Aug 3, 2023

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Aug 1, 2023

What problem does this PR solve?

Issue Number: Close #6875

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    pd0: ./pd-server services api
    tso1: ./pd-server services tso --listen-addr="http://127.0.0.1:3380" --backend-endpoints="http://127.0.0.1:2379"
    tso2: ./pd-server services tso --listen-addr="http://127.0.0.1:3379" --backend-endpoints="http://127.0.0.1:2379"

can find register key
image

then close pd0 and wait a minutes and can see keepalive failed log
image

and restart pd0 and can see normal and no keepalive failed log anymore
image
image

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and rleungx August 1, 2023 10:08
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 1, 2023
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #6876 (6449ae5) into master (d664827) will decrease coverage by 0.04%.
The diff coverage is 52.00%.

❗ Current head 6449ae5 differs from pull request most recent head 8ab03aa. Consider uploading reports for the commit 8ab03aa to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6876      +/-   ##
==========================================
- Coverage   74.09%   74.05%   -0.04%     
==========================================
  Files         427      420       -7     
  Lines       44968    44200     -768     
==========================================
- Hits        33318    32732     -586     
+ Misses       8696     8556     -140     
+ Partials     2954     2912      -42     
Flag Coverage Δ
unittests 74.05% <52.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 1, 2023
Signed-off-by: lhy1024 <admin@liudos.us>
pkg/mcs/discovery/register.go Outdated Show resolved Hide resolved
pkg/mcs/discovery/register.go Outdated Show resolved Hide resolved
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2023
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2023
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
Copy link
Contributor Author

lhy1024 commented Aug 2, 2023

The test can also pass in the master branch.

Thanks, I have ensured master branch cannot pass with new test

image

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 3, 2023
Signed-off-by: lhy1024 <admin@liudos.us>
@rleungx
Copy link
Member

rleungx commented Aug 3, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

This pull request has been accepted and is ready to merge.

Commit hash: ea39e66

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 6377b26 into tikv:master Aug 3, 2023
22 checks passed
@lhy1024 lhy1024 deleted the fix-ticker branch August 3, 2023 03:22
JmPotato pushed a commit to JmPotato/pd that referenced this pull request Sep 25, 2023
close tikv#6875

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 1, 2023
close tikv#6875

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep alive ticker is wrongly stopped
3 participants