New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mcs: fix ticker stop in register #6876
Conversation
Signed-off-by: lhy1024 <admin@liudos.us>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: lhy1024 <admin@liudos.us>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6876 +/- ##
==========================================
- Coverage 74.09% 74.05% -0.04%
==========================================
Files 427 420 -7
Lines 44968 44200 -768
==========================================
- Hits 33318 32732 -586
+ Misses 8696 8556 -140
+ Partials 2954 2912 -42
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: ea39e66
|
@lhy1024: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: Close #6875
What is changed and how does it work?
Check List
Tests
pd0:
./pd-server services api
tso1:
./pd-server services tso --listen-addr="http://127.0.0.1:3380" --backend-endpoints="http://127.0.0.1:2379"
tso2:
./pd-server services tso --listen-addr="http://127.0.0.1:3379" --backend-endpoints="http://127.0.0.1:2379"
can find register key
then close pd0 and wait a minutes and can see keepalive failed log
and restart pd0 and can see normal and no keepalive failed log anymore
Release note