Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistic: fix the issue of tombstone for label counter #2060

Merged
merged 4 commits into from
Dec 30, 2019

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Dec 30, 2019

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Fix issue #2004. Do not count the tombstone store.

What is changed and how it works?

Do not count the tombstone store.

Check List

  • Unit test

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch added type/bug The issue is confirmed as a bug. component/metrics Metrics. labels Dec 30, 2019
@nolouch nolouch added this to the v4.0.0-beta milestone Dec 30, 2019
@nolouch nolouch added needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. labels Dec 30, 2019
@codecov-io
Copy link

Codecov Report

Merging #2060 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2060      +/-   ##
==========================================
+ Coverage   76.63%   76.72%   +0.09%     
==========================================
  Files         189      189              
  Lines       19231    19233       +2     
==========================================
+ Hits        14737    14757      +20     
+ Misses       3374     3355      -19     
- Partials     1120     1121       +1
Impacted Files Coverage Δ
server/statistics/store_collection.go 59.25% <100%> (+16.4%) ⬆️
server/kv/etcd_kv.go 72.72% <0%> (-11.69%) ⬇️
server/region_syncer/client.go 78.31% <0%> (-2.41%) ⬇️
server/core/storage.go 71.35% <0%> (-1.05%) ⬇️
server/member/leader.go 78.57% <0%> (-1.03%) ⬇️
server/config/option.go 90.32% <0%> (-0.93%) ⬇️
server/server.go 81.85% <0%> (-0.38%) ⬇️
server/handler.go 50.85% <0%> (+0.42%) ⬆️
server/grpc_service.go 58.96% <0%> (+0.43%) ⬆️
client/client.go 73.44% <0%> (+1.2%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdb5973...ab0e352. Read the comment docs.

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhy1024
Copy link
Contributor

lhy1024 commented Dec 30, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 30, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 30, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 30, 2019

@nolouch merge failed.

@nolouch
Copy link
Contributor Author

nolouch commented Dec 30, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 30, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 30, 2019

cherry pick to release-3.0 in PR #2067

@sre-bot
Copy link
Contributor

sre-bot commented Dec 30, 2019

cherry pick to release-3.1 in PR #2068

nolouch pushed a commit that referenced this pull request Dec 31, 2019
* statistic: fix the issue of tombstone for label counter

Signed-off-by: nolouch <nolouch@gmail.com>
nolouch pushed a commit that referenced this pull request Dec 31, 2019
* statistic: fix the issue of tombstone for label counter

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics Metrics. needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. status/can-merge Indicates a PR has been approved by a committer. type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants