Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistic: fix the issue of tombstone for label counter (#2060) #2067

Merged
merged 2 commits into from
Dec 31, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Dec 30, 2019

cherry-pick #2060 to release-3.0


Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Fix issue #2004. Do not count the tombstone store.

What is changed and how it works?

Do not count the tombstone store.

Check List

  • Unit test

Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
@sre-bot sre-bot added component/metrics Metrics. status/can-merge Indicates a PR has been approved by a committer. cherry-pick type/bug The issue is confirmed as a bug. labels Dec 30, 2019
@codecov-io
Copy link

Codecov Report

Merging #2067 into release-3.0 will decrease coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.0    #2067      +/-   ##
===============================================
- Coverage        69.52%   69.48%   -0.05%     
===============================================
  Files              170      170              
  Lines            16800    16802       +2     
===============================================
- Hits             11681    11675       -6     
- Misses            4145     4151       +6     
- Partials           974      976       +2
Impacted Files Coverage Δ
server/statistics/store_collection.go 85% <66.66%> (-0.51%) ⬇️
pkg/etcdutil/etcdutil.go 79.06% <0%> (-6.98%) ⬇️
server/util.go 68.15% <0%> (-4.46%) ⬇️
server/tso.go 74.46% <0%> (-2.13%) ⬇️
server/namespace_cluster.go 85.71% <0%> (+3.89%) ⬆️
server/schedulers/random_merge.go 67.5% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 456c42b...ca182d4. Read the comment docs.

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rleungx
Copy link
Member

rleungx commented Dec 31, 2019

/run-all-tests

@nolouch nolouch merged commit 330c108 into tikv:release-3.0 Dec 31, 2019
@nolouch nolouch modified the milestones: v2.0.12, v3.0.9 Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics Metrics. status/can-merge Indicates a PR has been approved by a committer. type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants