Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region: Add accelerate regions schedule API (#2599) #2687

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2599 to release-4.0


Add one new region HTTP API.

What problem does this PR solve?

close #2593

What is changed and how it works?

Add one new region related http api to accelerate regions schedule by given key range.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Support Region HTTP API to promote regions schedule by given key range

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

@Yisaer please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/pd/invitations

Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor Author

@Yisaer,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: scheduling(slack).

@HunDunDM HunDunDM modified the milestones: v4.0.4, v4.0.5 Jul 29, 2020
@Yisaer
Copy link
Contributor

Yisaer commented Jul 29, 2020

/run-all-tests

@codecov-commenter
Copy link

Codecov Report

Merging #2687 into release-4.0 will increase coverage by 0.15%.
The diff coverage is 46.34%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2687      +/-   ##
===============================================
+ Coverage        77.00%   77.16%   +0.15%     
===============================================
  Files              205      205              
  Lines            22276    22317      +41     
===============================================
+ Hits             17154    17220      +66     
+ Misses            3810     3790      -20     
+ Partials          1312     1307       -5     
Impacted Files Coverage Δ
server/api/region.go 70.21% <45.00%> (-3.62%) ⬇️
server/api/router.go 99.30% <100.00%> (+<0.01%) ⬆️
server/schedule/operator/step.go 65.40% <0.00%> (-2.71%) ⬇️
server/region_syncer/client.go 79.38% <0.00%> (-2.30%) ⬇️
pkg/btree/btree.go 86.84% <0.00%> (-0.81%) ⬇️
server/member/leader.go 71.20% <0.00%> (-0.78%) ⬇️
server/schedule/operator_controller.go 81.41% <0.00%> (+0.16%) ⬆️
server/cluster/cluster.go 81.01% <0.00%> (+0.31%) ⬆️
server/handler.go 50.76% <0.00%> (+0.43%) ⬆️
server/grpc_service.go 59.84% <0.00%> (+0.77%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df95665...a58d894. Read the comment docs.

@Yisaer Yisaer merged commit 4108b4b into tikv:release-4.0 Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/api HTTP API. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants