Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "non-default keyspace groups use the same timestamp path by mistake" #6457
Fix "non-default keyspace groups use the same timestamp path by mistake" #6457
Changes from 8 commits
bab5b56
4c219c3
6450fd2
b07d8b1
cc10dde
34705ec
68b1950
2a4102a
52d3f88
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 280 in pkg/tso/allocator_manager.go
pkg/tso/allocator_manager.go#L280
Check warning on line 291 in pkg/tso/allocator_manager.go
pkg/tso/allocator_manager.go#L291
Check warning on line 152 in pkg/tso/global_allocator.go
pkg/tso/global_allocator.go#L152
Check warning on line 69 in pkg/tso/local_allocator.go
pkg/tso/local_allocator.go#L69
Check warning on line 92 in pkg/tso/local_allocator.go
pkg/tso/local_allocator.go#L91-L92
Check warning on line 94 in pkg/tso/local_allocator.go
pkg/tso/local_allocator.go#L94
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we test the correct timestamp paths are used for all keyspace groups.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to explicitly to call this line, because the keyspace group manager will automatically finish the split when it's first time serving the tso request for the split target group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call keyspace group manager's HandleTSORequest() instead of primary.GetTSOAllocatorManager(keyspaceGroupID) to trigger split process.