-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdutil: update member when unavailable #6462
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
pkg/utils/etcdutil/etcdutil.go
Outdated
key := "/etcd/healthy" | ||
client.Put(ctx, key, "") | ||
lastMembers := make([]string, 0) | ||
ticker := time.NewTicker(1 * time.Second) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure whether it is suitable.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6462 +/- ##
==========================================
+ Coverage 74.61% 74.84% +0.23%
==========================================
Files 417 410 -7
Lines 43089 41794 -1295
==========================================
- Hits 32150 31282 -868
+ Misses 8090 7800 -290
+ Partials 2849 2712 -137
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
It will be fix by #6577 |
What problem does this PR solve?
Issue Number: Close #6442
What is changed and how does it work?
Before etcd support balancer with only leader, we will use a goroutine to detect timeout and update members.
But we need more tests, so it is only used in mcs.
Check List
Tests
3 network partition + 3 leader io hang
10 network partition
Release note