Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdutil: update member when unavailable #6462

Closed
wants to merge 3 commits into from

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented May 14, 2023

What problem does this PR solve?

Issue Number: Close #6442

What is changed and how does it work?

Before etcd support balancer with only leader, we will use a goroutine to detect timeout and update members.

But we need more tests, so it is only used in mcs.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

3 network partition + 3 leader io hang
image
image

10 network partition
image

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 14, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels May 14, 2023
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx May 14, 2023 15:18
key := "/etcd/healthy"
client.Put(ctx, key, "")
lastMembers := make([]string, 0)
ticker := time.NewTicker(1 * time.Second)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure whether it is suitable.

@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Patch coverage: 92.30% and project coverage change: +0.23 🎉

Comparison is base (ac31f87) 74.61% compared to head (62d99de) 74.84%.

❗ Current head 62d99de differs from pull request most recent head b19da74. Consider uploading reports for the commit b19da74 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6462      +/-   ##
==========================================
+ Coverage   74.61%   74.84%   +0.23%     
==========================================
  Files         417      410       -7     
  Lines       43089    41794    -1295     
==========================================
- Hits        32150    31282     -868     
+ Misses       8090     7800     -290     
+ Partials     2849     2712     -137     
Flag Coverage Δ
unittests 74.84% <92.30%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/utils/etcdutil/etcdutil.go 83.51% <92.10%> (+3.90%) ⬆️
pkg/mcs/resource_manager/server/server.go 52.99% <100.00%> (ø)
pkg/mcs/tso/server/server.go 53.81% <100.00%> (-0.94%) ⬇️

... and 165 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2023
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 21, 2023
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jun 30, 2023

It will be fix by #6577

@lhy1024 lhy1024 closed this Jun 30, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QPS drops to zero after isolating PD leader
1 participant