Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tso: fix flaky test TestHandleTSORequestWithWrongMembership #6533

Merged
merged 1 commit into from
May 29, 2023
Merged

tso: fix flaky test TestHandleTSORequestWithWrongMembership #6533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions pkg/tso/keyspace_group_manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,11 +526,33 @@ func (suite *keyspaceGroupManagerTestSuite) TestHandleTSORequestWithWrongMembers
err := mgr.Initialize()
re.NoError(err)

// Should fail because keyspace 0 is not in keyspace group 1 and the API returns
// the keyspace group 0 to which the keyspace 0 belongs.
// Wait until the keyspace group 0 is ready for serving tso requests.
testutil.Eventually(re, func() bool {
member, err := mgr.GetElectionMember(0, 0)
if err != nil {
return false
}
return member.IsLeader()
}, testutil.WithWaitFor(5*time.Second), testutil.WithTickInterval(50*time.Millisecond))

// Should succeed because keyspace 0 is actually in keyspace group 0, which is served
// by the current keyspace group manager, instead of keyspace group 1 in ask, and
// keyspace group 0 is returned in the response.
_, keyspaceGroupBelongTo, err := mgr.HandleTSORequest(0, 1, GlobalDCLocation, 1)
re.Error(err)
re.NoError(err)
re.Equal(uint32(0), keyspaceGroupBelongTo)

// Should succeed because keyspace 100 doesn't belong to any keyspace group, so it will
// be served by the default keyspace group 0, and keyspace group 0 is returned in the response.
_, keyspaceGroupBelongTo, err = mgr.HandleTSORequest(100, 0, GlobalDCLocation, 1)
re.NoError(err)
re.Equal(uint32(0), keyspaceGroupBelongTo)

// Should fail because keyspace 100 doesn't belong to any keyspace group, and the keyspace group
// 1 in ask doesn't exist.
_, keyspaceGroupBelongTo, err = mgr.HandleTSORequest(100, 1, GlobalDCLocation, 1)
re.Error(err)
re.Equal(uint32(1), keyspaceGroupBelongTo)
}

type etcdEvent struct {
Expand Down