Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add configuration fileds to codecov.yaml #6666

Merged
merged 3 commits into from
Jul 3, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 17 additions & 0 deletions codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,20 @@ coverage:
# basic
target: auto
threshold: 3%

comment:
layout: "header, diff, flags"
behavior: default
require_changes: false

flag_management:
default_rules: # the rules that will be followed for any flag added, generally
carryforward: true
statuses:
- type: project
target: 85%
wuhuizuo marked this conversation as resolved.
Show resolved Hide resolved
- type: patch
target: 85%
wuhuizuo marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

@HuSharp HuSharp Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed codecov failed too much, which influenced the confirmation of the ci failure.
Is it too high for now? cc @wuhuizuo @purelind
image


ignore:
- tests/** # integration test cases or tools.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does ignoring here will reduce the test coverage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, but they are test tools or integration test cases, should be ignored.