ci: add configuration fileds to codecov.yaml #6666

wuhuizuo · 2023-06-25T07:39:45Z

What problem does this PR solve?

Ref:

How to make the testing observable by coverage data PingCAP-QE/ci#2171

Issue Number: Close #6667

What is changed and how does it work?

ci: add configuration fileds to codecov.yaml

- `ignore`: ignore integration test cases or tools paths.
- `flags`: to split static for unit and integration testing.
- `comment`: add `flags` section in comments.

Check List

Tests

No code

Code changes

None

Side effects

None

Related changes

None

Release note

None.

ti-chi-bot · 2023-06-25T07:39:47Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

nolouch
purelind

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2023-06-25T07:39:55Z

Hi @wuhuizuo. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wuhuizuo · 2023-06-25T07:45:56Z

/label ?

ti-chi-bot · 2023-06-25T07:45:58Z

@wuhuizuo: The label(s) ? cannot be applied. These labels are supported: Hacktoberfest, challenge-program, ci-unstable, compatibility-breaker, high-performance, hptc, needs-cherry-pick-release-5.1, needs-cherry-pick-release-5.2, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.0, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.2, needs-cherry-pick-release-6.3, needs-cherry-pick-release-6.4, needs-cherry-pick-release-6.5, needs-cherry-pick-release-6.6, needs-cherry-pick-release-7.0, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.2, release-note, require-LGT1, wontfix, affects-5.1, affects-5.2, affects-5.3, affects-5.4, affects-6.0, affects-6.1, affects-6.2, affects-6.3, affects-6.4, affects-6.5, affects-6.6, affects-7.0, affects-7.1, affects-7.2, may-affects-5.1, may-affects-5.2, may-affects-5.3, may-affects-5.4, may-affects-6.0, may-affects-6.1, may-affects-6.2, may-affects-6.3, may-affects-6.4, may-affects-6.5, may-affects-6.6, may-affects-7.0, may-affects-7.1, may-affects-7.2.

In response to this:

/label ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-25T07:50:24Z

~

codecov · 2023-06-25T07:57:45Z

Codecov Report

Merging #6666 (a5a9e9f) into master (53d5a92) will decrease coverage by 0.27%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6666      +/-   ##
==========================================
- Coverage   74.56%   74.30%   -0.27%     
==========================================
  Files         417      410       -7     
  Lines       43630    42792     -838     
==========================================
- Hits        32534    31795     -739     
+ Misses       8203     8135      -68     
+ Partials     2893     2862      -31

Flag	Coverage Δ
unittests	`74.30% <ø> (-0.27%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov.yml

nolouch · 2023-06-26T05:42:07Z

codecov.yml

+        target: 70%
+
+ignore:
+  - tests/** # integration test cases or tools.


Does ignoring here will reduce the test coverage?

Maybe, but they are test tools or integration test cases, should be ignored.

- `ignore`: ignore integration test cases or tools paths. - `flags`: to split static for unit and integration testing. - `comment`: add `flags` section in comments. Signed-off-by: wuhuizuo <wuhuizuo@126.com>

purelind · 2023-06-27T02:45:44Z

/ok-to-test

purelind

/lgtm

purelind · 2023-07-03T05:54:17Z

/merge

ti-chi-bot · 2023-07-03T05:54:18Z

@purelind: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-03T05:54:20Z

This pull request has been accepted and is ready to merge.

Commit hash: a5a9e9f

HuSharp · 2023-07-03T08:38:16Z

codecov.yml

+      - type: project
+        target: 85%
+      - type: patch
+        target: 85%


I noticed codecov failed too much, which influenced the confirmation of the ci failure.
Is it too high for now? cc @wuhuizuo @purelind

ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none labels Jun 25, 2023

ti-chi-bot bot requested review from lhy1024 and rleungx June 25, 2023 07:39

ti-chi-bot bot added the needs-ok-to-test label Jun 25, 2023

ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 25, 2023

ti-chi-bot bot removed the do-not-merge/needs-linked-issue label Jun 25, 2023

wuhuizuo commented Jun 25, 2023

View reviewed changes

codecov.yml Show resolved Hide resolved

wuhuizuo commented Jun 25, 2023

View reviewed changes

codecov.yml Show resolved Hide resolved

nolouch approved these changes Jun 26, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 26, 2023

nolouch reviewed Jun 26, 2023

View reviewed changes

ci: add configuration fileds to codecov.yaml

74d129f

- `ignore`: ignore integration test cases or tools paths. - `flags`: to split static for unit and integration testing. - `comment`: add `flags` section in comments. Signed-off-by: wuhuizuo <wuhuizuo@126.com>

wuhuizuo force-pushed the ci/update-codecov-config branch from 593f5d5 to 74d129f Compare June 27, 2023 02:44

ti-chi-bot bot added ok-to-test and removed needs-ok-to-test labels Jun 27, 2023

purelind approved these changes Jun 27, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 27, 2023

wuhuizuo added 2 commits June 30, 2023 20:47

Merge branch 'master' into ci/update-codecov-config

8be6f19

Merge branch 'master' into ci/update-codecov-config

a5a9e9f

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 3, 2023

ti-chi-bot bot merged commit 626d1c8 into tikv:master Jul 3, 2023
25 of 26 checks passed

HuSharp reviewed Jul 3, 2023

View reviewed changes

wuhuizuo deleted the ci/update-codecov-config branch August 24, 2023 07:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: add configuration fileds to codecov.yaml #6666

ci: add configuration fileds to codecov.yaml #6666

wuhuizuo commented Jun 25, 2023 •

edited

ti-chi-bot bot commented Jun 25, 2023 •

edited

ti-chi-bot bot commented Jun 25, 2023

wuhuizuo commented Jun 25, 2023

ti-chi-bot bot commented Jun 25, 2023

ti-chi-bot commented Jun 25, 2023 •

edited

codecov bot commented Jun 25, 2023 •

edited

nolouch Jun 26, 2023

wuhuizuo Jun 27, 2023

purelind commented Jun 27, 2023

purelind left a comment

purelind commented Jul 3, 2023

ti-chi-bot bot commented Jul 3, 2023

ti-chi-bot bot commented Jul 3, 2023

HuSharp Jul 3, 2023 •

edited

ci: add configuration fileds to codecov.yaml #6666

ci: add configuration fileds to codecov.yaml #6666

Conversation

wuhuizuo commented Jun 25, 2023 • edited

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Jun 25, 2023 • edited

ti-chi-bot bot commented Jun 25, 2023

wuhuizuo commented Jun 25, 2023

ti-chi-bot bot commented Jun 25, 2023

ti-chi-bot commented Jun 25, 2023 • edited

codecov bot commented Jun 25, 2023 • edited

Codecov Report

nolouch Jun 26, 2023

Choose a reason for hiding this comment

wuhuizuo Jun 27, 2023

Choose a reason for hiding this comment

purelind commented Jun 27, 2023

purelind left a comment

Choose a reason for hiding this comment

purelind commented Jul 3, 2023

ti-chi-bot bot commented Jul 3, 2023

ti-chi-bot bot commented Jul 3, 2023

HuSharp Jul 3, 2023 • edited

Choose a reason for hiding this comment

wuhuizuo commented Jun 25, 2023 •

edited

ti-chi-bot bot commented Jun 25, 2023 •

edited

ti-chi-bot commented Jun 25, 2023 •

edited

codecov bot commented Jun 25, 2023 •

edited

HuSharp Jul 3, 2023 •

edited