New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource_manager: fix gosigar import package #6735
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@@ -9,6 +9,7 @@ require ( | |||
github.com/prometheus/client_golang v1.11.1 | |||
github.com/tikv/pd/client v0.0.0-00010101000000-000000000000 | |||
go.uber.org/zap v1.24.0 | |||
google.golang.org/grpc v1.54.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why import this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because this pr forget to add it
https://github.com/tikv/pd/pull/6699/files#diff-6e9d6d039becbedf1b1469724f64b7a7c5ecf74a0d9bc24b29ca5e0681443ccdR36
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6735 +/- ##
==========================================
+ Coverage 74.31% 74.53% +0.21%
==========================================
Files 411 417 +6
Lines 42960 43630 +670
==========================================
+ Hits 31927 32520 +593
- Misses 8176 8216 +40
- Partials 2857 2894 +37
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: husharp <jinhao.hu@pingcap.com>
/check-issue-triage-complete |
/merge |
@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 484c5fd
|
@HuSharp: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: Close #6734
What is changed and how does it work?
Check List
Tests
Release note