Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource_manage: fix gosigar import package #6734

Closed
HuSharp opened this issue Jul 3, 2023 · 0 comments · Fixed by #6735
Closed

resource_manage: fix gosigar import package #6734

HuSharp opened this issue Jul 3, 2023 · 0 comments · Fixed by #6735
Labels
severity/minor type/bug The issue is confirmed as a bug.

Comments

@HuSharp
Copy link
Member

HuSharp commented Jul 3, 2023

Bug Report

What did you do?

In TiDB we introduced cloudfoundry/gosigar
But in PD we introduced elastic/gosigar
Some compatibility issues may be encountered in both components

for TiDB: https://github.com/pingcap/tidb/blob/b18d0ebef57890faa23265154227ecd13b944130/util/cpu/cpu.go#L22
for PD: https://github.com/tikv/pd/blob/master/client/resource_group/controller/model.go#L21

What did you expect to see?

TiDB and PD package be consistent.

What did you see instead?

In TiDB we introduced cloudfoundry/gosigar
But in PD we introduced elastic/gosigar

What version of PD are you using (pd-server -V)?

master
@HuSharp HuSharp added the type/bug The issue is confirmed as a bug. label Jul 3, 2023
@HuSharp HuSharp mentioned this issue Jul 3, 2023
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in #6735 Jul 4, 2023
ti-chi-bot bot added a commit that referenced this issue Jul 4, 2023
@HuSharp @ti-chi-bot
resource_manage: fix gosigar import package (#6735)
a7eedd2 
close #6734

In TiDB we introduced cloudfoundry/gosigar
But in PD we introduced elastic/gosigar
Some compatibility issues may be encountered in both components

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resource_manager: fix gosigar import package HuSharp/pd
1 participant
@HuSharp