Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resourcemanager: return resource-group priority in OnRequestWait (#7378) #7383

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7378

What problem does this PR solve?

Issue Number: close #7379, ref tikv/tikv#15994

What is changed and how does it work?

return resource-group priority in OnRequestWait so client-go can set the resource-group priority to kv request.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

None

Signed-off-by: glorv <glorvs@163.com>
@ti-chi-bot ti-chi-bot added release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 16, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 16, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #7383 (ffc3fc5) into release-7.5 (d0a17ca) will increase coverage by 0.03%.
The diff coverage is 80.00%.

❗ Current head ffc3fc5 differs from pull request most recent head 4255a28. Consider uploading reports for the commit 4255a28 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.5    #7383      +/-   ##
===============================================
+ Coverage        74.61%   74.64%   +0.03%     
===============================================
  Files              442      442              
  Lines            47822    47822              
===============================================
+ Hits             35682    35699      +17     
+ Misses            8985     8969      -16     
+ Partials          3155     3154       -1     
Flag Coverage Δ
unittests 74.64% <80.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 16, 2023
close tikv#7360

Prevent `loadServerConfig` from panic.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@nolouch
Copy link
Contributor

nolouch commented Nov 16, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 16, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 16, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 4255a28

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 16, 2023
@ti-chi-bot ti-chi-bot bot merged commit ef6ba85 into tikv:release-7.5 Nov 16, 2023
20 checks passed
@glorv glorv deleted the cherry-pick-7378-to-release-7.5 branch November 16, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants