Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release 7.5.0 Compared with the previous commit, oltp_read_write has a 3.65% regression under 200 concurrency and oltp_insert has a 1.5+% regression under 100 concurrency #15994

Closed
shaoxiqian opened this issue Nov 15, 2023 · 6 comments · Fixed by #16003
Closed

release 7.5.0 Compared with the previous commit, oltp_read_write has a 3.65% regression under 200 concurrency and oltp_insert has a 1.5+% regression under 100 concurrency #15994

shaoxiqian opened this issue Nov 15, 2023 · 6 comments · Fixed by #16003
Assignees
@glorv
Labels
affects-7.5 severity/critical type/bug Type: Issue - Confirmed a bug

Comments

@shaoxiqian
Copy link

shaoxiqian commented Nov 15, 2023 •
edited

Bug Report

What version of TiKV are you using?

7.1.2 tidb + 7.1.2 pd + patch 7.5.0 tikv

What operating system and CPU are you using?

ksyun-rocky-16c

Steps to reproduce

cluster deploy
7.1.2 tidb + 7.1.2 pd + patch 7.5.0 tikv(commit id 9bece34)
7.1.2 tidb + 7.1.2 pd + patch 7.5.0 tikv(commit id 076b79c)

workload
sysbench oltp_read_write /oltp_insert
threads=100/200

What did you expect?

Compared with 7.1.2 under 200 concurrency, qps should also be similar.

What did happened?

Compared with the tikv 7.1.2, tikv 7.5.0 has a 5.82% regression under 200 concurrency in oltp_read_write.
image
Compared with the commit 9bece34 the commit 076b79c lead oltp_read_write has a 3.65% regression under 200 concurrency and oltp_insert has a 1.5+% regression under 100 concurrency
image
image

The corresponding pr is #15966
@shaoxiqian shaoxiqian added the type/bug Type: Issue - Confirmed a bug label Nov 15, 2023
@shaoxiqian
Copy link
Author

/type performance

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2023

@shaoxiqian: The label(s) type/performance cannot be applied, because the repository doesn't have them.

In response to this:

/type performance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@shaoxiqian
Copy link
Author

/type regression

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2023

@shaoxiqian: The label(s) type/regression cannot be applied, because the repository doesn't have them.

In response to this:

/type regression

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@shaoxiqian
Copy link
Author

/label affects-7.5

@shaoxiqian
Copy link
Author

/assign @glorv

@glorv glorv mentioned this issue Nov 16, 2023
Merged
@glorv glorv mentioned this issue Nov 16, 2023
Merged
ti-chi-bot bot added a commit to tikv/pd that referenced this issue Nov 16, 2023
@glorv @ti-chi-bot
resourcemanager: return resource-group priority in OnRequestWait (#7378)
4e600c2 
close #7379, ref tikv/tikv#15994

Signed-off-by: glorv <glorvs@163.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 16, 2023
Merged
@glorv glorv mentioned this issue Nov 16, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Nov 16, 2023
@glorv
resource_control: do not force set override priority at handle gRPC r…
a0dbe2d 
…equest (#16003)

close #15994

Signed-off-by: glorv <glorvs@163.com>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 16, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Nov 16, 2023
@ti-chi-bot @glorv
resource_control: do not force set override priority at handle gRPC r…
10c9d52 
…equest (#16003) (#16004)

close #15994

Signed-off-by: glorv <glorvs@163.com>

Co-authored-by: glorv <glorvs@163.com>
ti-chi-bot bot pushed a commit to tikv/pd that referenced this issue Nov 16, 2023
@ti-chi-bot @glorv @JmPotato
resourcemanager: return resource-group priority in OnRequestWait (#7378…
ef6ba85 
…) (#7383)

close #7379, ref tikv/tikv#15994

Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: glorv <glorvs@163.com>
Co-authored-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glorv glorv

Labels
affects-7.5 severity/critical type/bug Type: Issue - Confirmed a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resource_control: do not force set override priority at handle gRPC request glorv/tikv
2 participants
@glorv @shaoxiqian