Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix TestClientClusterIDCheck panic #7764

Closed
wants to merge 1 commit into from

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 25, 2024

What problem does this PR solve?

Issue Number: Close #7763.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Jan 25, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and lhy1024 January 25, 2024 09:19
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 25, 2024
@rleungx rleungx changed the title *: fix test panic *: fix TestClientClusterIDCheck panic Jan 25, 2024
@rleungx rleungx requested review from CabinfeverB and removed request for HunDunDM January 25, 2024 09:22
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Merging #7764 (d1f1e64) into master (9a82b47) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7764      +/-   ##
==========================================
- Coverage   70.01%   70.01%   -0.01%     
==========================================
  Files         430      430              
  Lines       47641    47641              
==========================================
- Hits        33355    33354       -1     
- Misses      11530    11538       +8     
+ Partials     2756     2749       -7     
Flag Coverage Δ
unittests 70.01% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2024
@HuSharp
Copy link
Member

HuSharp commented Jan 29, 2024

can be fixed in #7766

@HuSharp
Copy link
Member

HuSharp commented Jan 29, 2024

closed by #7766

@HuSharp HuSharp closed this Jan 29, 2024
@rleungx rleungx deleted the stable-test21 branch January 29, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestClientClusterIDCheck panic
3 participants