Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-subtask: exit ci-subtask.sh when execute ci failed #7766

Merged
merged 7 commits into from Jan 29, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Jan 25, 2024

What problem does this PR solve?

Issue Number: Close #7770

What is changed and how does it work?

need to exit when execute failed

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Jan 25, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from JmPotato and lhy1024 January 25, 2024 15:49
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Merging #7766 (79c5221) into master (cf02b18) will increase coverage by 3.71%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7766      +/-   ##
==========================================
+ Coverage   69.76%   73.48%   +3.71%     
==========================================
  Files         430      430              
  Lines       47632    47635       +3     
==========================================
+ Hits        33231    35003    +1772     
+ Misses      11652     9627    -2025     
- Partials     2749     3005     +256     
Flag Coverage Δ
unittests 73.48% <100.00%> (+3.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@HuSharp HuSharp force-pushed the check_ci branch 3 times, most recently from aa4aaac to 653b20c Compare January 26, 2024 00:55
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2024
@HuSharp HuSharp force-pushed the check_ci branch 2 times, most recently from 2d8f443 to 6ef06c1 Compare January 26, 2024 01:08
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 26, 2024
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp changed the title check ci-subtask: exit ci-subtask.sh when execute ci failed Jan 29, 2024
@HuSharp
Copy link
Member Author

HuSharp commented Jan 29, 2024

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 29, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 29, 2024
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Copy link
Member

@CabinfeverB CabinfeverB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REST LGTM

scripts/ci-subtask.sh Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 29, 2024
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@rleungx
Copy link
Member

rleungx commented Jan 29, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jan 29, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 29, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 79c5221

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 29, 2024
@ti-chi-bot ti-chi-bot bot merged commit ef6bdf1 into tikv:master Jan 29, 2024
25 of 26 checks passed
@HuSharp HuSharp deleted the check_ci branch January 29, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci didn't report an error
5 participants