-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: fix patrol panel #8116
Conversation
Signed-off-by: lhy1024 <admin@liudos.us>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8116 +/- ##
==========================================
+ Coverage 77.35% 77.38% +0.02%
==========================================
Files 471 471
Lines 61348 61348
==========================================
+ Hits 47458 47473 +15
+ Misses 10314 10306 -8
+ Partials 3576 3569 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
metrics/grafana/pd.json
Outdated
@@ -7909,7 +7909,7 @@ | |||
"tableColumn": "", | |||
"targets": [ | |||
{ | |||
"expr": "pd_checker_patrol_regions_time{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\"} != 0", | |||
"expr": "max(pd_checker_patrol_regions_time{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\"})", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think max is right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will it auto-hidden if no scheduling service?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we use the latest one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be complex to return the latest values from multiple time series. https://stackoverflow.com/questions/76930324/return-most-recent-value-of-multiple-time-series-in-prometheus-promql
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're sure that patrol won't be reported by different nodes, perhaps we can use sum() directly.
Signed-off-by: lhy1024 <admin@liudos.us>
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 538e2f3
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: Close #8115
What is changed and how does it work?
Check List
Tests
tiup play ground with resign leader
Before
![image](https://private-user-images.githubusercontent.com/19542290/324726082-50ab49a1-8f85-4e65-8d9f-6cf76d576c40.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ0NTc0MTAsIm5iZiI6MTcyNDQ1NzExMCwicGF0aCI6Ii8xOTU0MjI5MC8zMjQ3MjYwODItNTBhYjQ5YTEtOGY4NS00ZTY1LThkOWYtNmNmNzZkNTc2YzQwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIzVDIzNTE1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkwOTZlNTBmZTRjMmY4NGUzMDk1NGVlNzBiODM1MTQwNjdiNDg3ZmE2MTdiOWQ0NTE1ZDY1ZDJmNjg4NmY4NWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.QwOnsft2q51ZG3Ex2DtsMI89fRG8c2RFRkaezUXpHtk)
After
![image](https://private-user-images.githubusercontent.com/19542290/324725867-085f53fe-2764-4b52-bb78-4ca90b520915.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ0NTc0MTAsIm5iZiI6MTcyNDQ1NzExMCwicGF0aCI6Ii8xOTU0MjI5MC8zMjQ3MjU4NjctMDg1ZjUzZmUtMjc2NC00YjUyLWJiNzgtNGNhOTBiNTIwOTE1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIzVDIzNTE1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk1NDgwMzcyYmZhNDcxY2ZmODJlYTdhODdlYjdhNWIyN2MwZjhhZDEyYjE5MDczZjFiYTczNmIzNWIyZjVkZDYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.kDZdUhQ-3wdmhF2Gkw4OSsre9C0jy5c38Xn4g0HfGfU)
tiup with ms
operator with ms
Release note