fix trigger listeners when open engine #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix listeners' post_new_log_file not triggered when reopening engine with existing log files in [tikv#132 ]. Add test to check if listeners have been triggered when recovering. Signed-off-by: MrCroxx <mrcroxx@outlook.com>
|
@tabokie PTAL |
tabokie
reviewed
Oct 28, 2021
src/engine.rs
Outdated
Comment on lines
620
to
621
| assert!(hook.0[&LogQueue::Append].files() > 0); | ||
| assert!(hook.0[&LogQueue::Rewrite].files() > 0); |
There was a problem hiding this comment.
assert they are equal to file_span().
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
tabokie
approved these changes
Oct 28, 2021
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix listeners' post_new_log_file not triggered when reopening
engine with existing log files in #132 .
Add test to check if listeners have been triggered when recovering.
Signed-off-by: MrCroxx mrcroxx@outlook.com