Remove entry cache #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
hicqu
reviewed
Jul 20, 2021
| let (file_id, offset, fd) = queue.on_append(content.len(), sync)?; | ||
| pwrite_exact(fd.0, offset, content)?; | ||
| (file_id, offset, fd) | ||
| }; | ||
| for listener in &self.listeners { | ||
| listener.on_append_log_file(queue, file_id); |
There was a problem hiding this comment.
on_append_log_file must be called during the append queue is locked.
hicqu
reviewed
Jul 20, 2021
src/file_pipe_log.rs
Outdated
| } else { | ||
| self.append_bytes(queue, &content, &mut sync)? | ||
| }; | ||
| #[allow(clippy::branches_sharing_code)] |
|
rest LGTM! |
Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
added a commit
that referenced
this pull request
Jul 21, 2021
Signed-off-by: tabokie <xy.tao@outlook.com>
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tabokie xy.tao@outlook.com
The existing entry cache implementation is overly complex (in order to maintain global FIFO eviction upon independent region caches), and is duplicated with caching at TiKV layer.