fix Clang 12 build errors #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Weber <greg@pingcap.com>
|
The Travis Mac Clang builds failed but it doesn't show any output. Can we retry these jobs? Is there a way to see the output? |
have triggered the retry of failed jobs |
|
Still failing with no logs.
…On Fri, Sep 25, 2020 at 12:21 AM Connor ***@***.***> wrote:
The Travis Mac Clang builds failed but it doesn't show any output. Can we
retry these jobs? Is there a way to see the output?
have triggered the retry of failed jobs
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#194 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAJHYDLBZSC6CJMIXYHUDSHQSFRANCNFSM4RYYE2WQ>
.
|
|
oh, it seems all the PRs are failing on these builds |
|
The CI is failing for timeout and irrelevant, but looks like they are the only Mac build CI we have. |
yiwu-arbug
pushed a commit
to tikv/rust-rocksdb
that referenced
this pull request
Oct 1, 2020
update rocksdb to include tikv/rocksdb#194 for master Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Closed
breezewish
pushed a commit
to breezewish/tikv-rocksdb
that referenced
this pull request
Dec 18, 2020
I needed these changes to run `make` successfully. See this issue which points out the problem and has the same patch solution but at a different point in time: facebook#7352 Signed-off-by: Breezewish <me@breeswish.org>
yiwu-arbug
pushed a commit
that referenced
this pull request
Dec 18, 2020
I needed these changes to run `make` successfully. See this issue which points out the problem and has the same patch solution but at a different point in time: facebook#7352 Signed-off-by: Breezewish <me@breeswish.org> Co-authored-by: Greg Weber <greg@gregweber.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed these changes to run
makesuccessfully.See this issue which points out the problem and has the same patch solution but at a different point in time: facebook#7352