table_cache: Generate unique ID based on db instance, file number (#205) #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kv#205) * table_cache: Generate unique ID based on db instance, file number This change updates the cache key prefix for SST files from relying on the inode generation number to using a passed-in unique ID. This ID is composed of a table-cache-specific random ID, as well as the number of the SST. This should resolve issues around cache collisions between two different SS tables that happened to have the same generation number. Signed-off-by: Connor1996 <zbk602423539@gmail.com> Co-authored-by: Bilal Akhtar <bilal@cockroachlabs.com>
tabokie
approved these changes
Nov 10, 2020
|
|
|
@Connor1996 yes. And feel free to remove these two CI from travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the cache key prefix for SST files from relying
on the inode generation number to using a passed-in unique ID. This
ID is composed of a table-cache-specific random ID, as well as the
number of the SST. This should resolve issues around cache collisions
between two different SS tables that happened to have the same
generation number.
Signed-off-by: Connor1996 zbk602423539@gmail.com
Co-authored-by: Bilal Akhtar bilal@cockroachlabs.com