*: add feature "push" #86
Conversation
| @@ -66,8 +69,6 @@ pub use self::histogram::{Histogram, HistogramVec, HistogramOpts, HistogramTimer | |||
| // Functions | |||
| pub use self::registry::{gather, register, unregister}; | |||
| pub use self::histogram::{linear_buckets, exponential_buckets}; | |||
| pub use self::push::{push_metrics, push_add_metrics, push_collector, push_add_collector, | |||
There was a problem hiding this comment.
Not sure what the backwards compatibility desires are at this point in the library's life, but the reexport could be maintained.
| use std::env; | ||
| use std::time; | ||
| use std::thread; | ||
| mod bridge { |
There was a problem hiding this comment.
Instead of this module, it is probably easier to conditionally change main:
#[cfg(not(feature = "push"))]
fn main() {
println!(r#"Please enable feature "push", try:
cargo run --features=push --example example_push"#);
}
#[cfg(feature = "push")]
fn main() {
// original main here
}You could then also have #![cfg_attr(not(feature = "push"), allow(warnings))] at the top of the file to disable warnings on the unused imports and lazy_static and so on.
There was a problem hiding this comment.
Yeah, that is much easier.
There was a problem hiding this comment.
wow it's even nicer than I thought it would be after that change! :-)
* reexport push functions * suppress warnings on none-push build
overvenus
force-pushed
the
push-feature
branch
from
ec7942e
to
6d458ba
Compare
|
PTAL @siddontang |
|
Do we need to update TiKV? |
|
LGTM |
|
PTAL @BusyJay |
| @@ -15,6 +15,7 @@ addons: | |||
| env: | |||
| global: | |||
| - RUSTFLAGS=--deny=warnings | |||
| - FEATURES=push | |||
There was a problem hiding this comment.
Should test whether everything works fine when the features is disabled.
Tests with no features enabled
|
PTAL @BusyJay |
|
LGTM |
This PR introduces a new feature
push. It allows building core instrumentation library without hyper and libc.There are a few API changes:modpushis published.following functions are moved to modpush.Close #84
PTAL @siddontang @kamalmarhubi