Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update submodules #712

Merged
merged 2 commits into from
Jul 18, 2022
Merged

update submodules #712

merged 2 commits into from
Jul 18, 2022

Conversation

sticnarf
Copy link

Include tikv/rocksdb@9c86bf5 to make it compile under GCC 12.

Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@sticnarf sticnarf requested a review from tabokie July 18, 2022 09:56
@tabokie
Copy link
Member

tabokie commented Jul 18, 2022

please include tikv/titan#255

@tabokie tabokie changed the title update rocksdb submodule update submodules Jul 18, 2022
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Copy link
Member

@ethercflow ethercflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link

@ethercflow, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: engine(slack).

@sticnarf sticnarf merged commit 827a5df into tikv:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants