Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise CONTRIBUTING.md contents. #14031

Closed
woofyzhao opened this issue Jan 10, 2023 · 24 comments · Fixed by #14032
Closed

Revise CONTRIBUTING.md contents. #14031

woofyzhao opened this issue Jan 10, 2023 · 24 comments · Fixed by #14032
Labels
type/enhancement Type: Issue - Enhancement

Comments

@woofyzhao
Copy link
Contributor

woofyzhao commented Jan 10, 2023 •
edited

Bug Report

What version of TiKV are you using?

master

What operating system and CPU are you using?

macOs, intel

Steps to reproduce

make build

What did you expect?

build success

What did happened?

Script complaining that protoc cannot be found and error quit
image

What do you suggest

  • Explicitly mention protoc as one of the prerequisites to build tikv in CONTRIBUTING.md upfront.
  • Fix some typo in the md doc.
  • Fix dead hyper links.
@woofyzhao woofyzhao mentioned this issue Jan 10, 2023
Merged
@ti-chi-bot
Copy link
Member

@woofyzhao: The label(s) type/bug cannot be applied. These labels are supported: challenge-program, compatibility-breaker, high-performance, hptc, wontfix, do-not-merge/cherry-pick-not-approved, needs-cherry-pick-release-2.1, needs-cherry-pick-release-3.0, needs-cherry-pick-release-3.1, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0, needs-cherry-pick-release-5.1, needs-cherry-pick-release-5.2, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.0, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.2, needs-cherry-pick-release-6.3, needs-cherry-pick-release-6.4, needs-cherry-pick-release-6.5, affects-4.0, affects-5.0, affects-5.1, affects-5.2, affects-5.3, affects-5.4, affects-6.0, affects-6.1, affects-6.2, affects-6.3, affects-6.4, affects-6.5, may-affects-4.0, may-affects-5.0, may-affects-5.1, may-affects-5.2, may-affects-5.3, may-affects-5.4, may-affects-6.0, may-affects-6.1, may-affects-6.2, may-affects-6.3, may-affects-6.4, may-affects-6.5.

In response to this:

/label type/bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

1 similar comment
@ti-chi-bot
Copy link
Member

@woofyzhao: The label(s) type/bug cannot be applied. These labels are supported: challenge-program, compatibility-breaker, high-performance, hptc, wontfix, do-not-merge/cherry-pick-not-approved, needs-cherry-pick-release-2.1, needs-cherry-pick-release-3.0, needs-cherry-pick-release-3.1, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0, needs-cherry-pick-release-5.1, needs-cherry-pick-release-5.2, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.0, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.2, needs-cherry-pick-release-6.3, needs-cherry-pick-release-6.4, needs-cherry-pick-release-6.5, affects-4.0, affects-5.0, affects-5.1, affects-5.2, affects-5.3, affects-5.4, affects-6.0, affects-6.1, affects-6.2, affects-6.3, affects-6.4, affects-6.5, may-affects-4.0, may-affects-5.0, may-affects-5.1, may-affects-5.2, may-affects-5.3, may-affects-5.4, may-affects-6.0, may-affects-6.1, may-affects-6.2, may-affects-6.3, may-affects-6.4, may-affects-6.5.

In response to this:

/label type/bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@woofyzhao
Copy link
Contributor Author

/type bug

@ti-chi-bot ti-chi-bot added the type/bug Type: Issue - Confirmed a bug label Jan 10, 2023
@woofyzhao
Copy link
Contributor Author

/severity doc

@ti-chi-bot
Copy link
Member

@woofyzhao: The label(s) severity/doc cannot be applied, because the repository doesn't have them.

In response to this:

/severity doc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@woofyzhao
Copy link
Contributor Author

/severity major

@woofyzhao woofyzhao changed the title [Doc] Revise CONTRIBUTING.md contents. Revise CONTRIBUTING.md contents. Jan 10, 2023
@woofyzhao
Copy link
Contributor Author

/remove-type bug

@ti-chi-bot ti-chi-bot removed the type/bug Type: Issue - Confirmed a bug label Jan 10, 2023
@woofyzhao
Copy link
Contributor Author

/remove-severity major

@woofyzhao
Copy link
Contributor Author

/remove-label may-affects-*

@ti-chi-bot
Copy link
Member

@woofyzhao: The label(s) may-affects-* cannot be applied. These labels are supported: challenge-program, compatibility-breaker, high-performance, hptc, wontfix, do-not-merge/cherry-pick-not-approved, needs-cherry-pick-release-2.1, needs-cherry-pick-release-3.0, needs-cherry-pick-release-3.1, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0, needs-cherry-pick-release-5.1, needs-cherry-pick-release-5.2, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.0, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.2, needs-cherry-pick-release-6.3, needs-cherry-pick-release-6.4, needs-cherry-pick-release-6.5, affects-4.0, affects-5.0, affects-5.1, affects-5.2, affects-5.3, affects-5.4, affects-6.0, affects-6.1, affects-6.2, affects-6.3, affects-6.4, affects-6.5, may-affects-4.0, may-affects-5.0, may-affects-5.1, may-affects-5.2, may-affects-5.3, may-affects-5.4, may-affects-6.0, may-affects-6.1, may-affects-6.2, may-affects-6.3, may-affects-6.4, may-affects-6.5.

In response to this:

/remove-label may-affects-*

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@woofyzhao: The label(s) doc cannot be applied. These labels are supported: challenge-program, compatibility-breaker, high-performance, hptc, wontfix, do-not-merge/cherry-pick-not-approved, needs-cherry-pick-release-2.1, needs-cherry-pick-release-3.0, needs-cherry-pick-release-3.1, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0, needs-cherry-pick-release-5.1, needs-cherry-pick-release-5.2, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.0, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.2, needs-cherry-pick-release-6.3, needs-cherry-pick-release-6.4, needs-cherry-pick-release-6.5, affects-4.0, affects-5.0, affects-5.1, affects-5.2, affects-5.3, affects-5.4, affects-6.0, affects-6.1, affects-6.2, affects-6.3, affects-6.4, affects-6.5, may-affects-4.0, may-affects-5.0, may-affects-5.1, may-affects-5.2, may-affects-5.3, may-affects-5.4, may-affects-6.0, may-affects-6.1, may-affects-6.2, may-affects-6.3, may-affects-6.4, may-affects-6.5.

In response to this:

/label doc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

1 similar comment
@ti-chi-bot
Copy link
Member

@woofyzhao: The label(s) doc cannot be applied. These labels are supported: challenge-program, compatibility-breaker, high-performance, hptc, wontfix, do-not-merge/cherry-pick-not-approved, needs-cherry-pick-release-2.1, needs-cherry-pick-release-3.0, needs-cherry-pick-release-3.1, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0, needs-cherry-pick-release-5.1, needs-cherry-pick-release-5.2, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.0, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.2, needs-cherry-pick-release-6.3, needs-cherry-pick-release-6.4, needs-cherry-pick-release-6.5, affects-4.0, affects-5.0, affects-5.1, affects-5.2, affects-5.3, affects-5.4, affects-6.0, affects-6.1, affects-6.2, affects-6.3, affects-6.4, affects-6.5, may-affects-4.0, may-affects-5.0, may-affects-5.1, may-affects-5.2, may-affects-5.3, may-affects-5.4, may-affects-6.0, may-affects-6.1, may-affects-6.2, may-affects-6.3, may-affects-6.4, may-affects-6.5.

In response to this:

/label doc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@woofyzhao: The label(s) type/doc cannot be applied, because the repository doesn't have them.

In response to this:

/type doc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@woofyzhao
Copy link
Contributor Author

/remove-label may-affects-4.0 may-affects-5.0

@woofyzhao
Copy link
Contributor Author

/remove-label may-affects-4.0

@woofyzhao
Copy link
Contributor Author

/remove-label may-affects-5.0
/remove-label may-affects-5.1
/remove-label may-affects-5.2
/remove-label may-affects-5.3
/remove-label may-affects-5.4

@woofyzhao
Copy link
Contributor Author

/remove-label may-affects-6.0
/remove-label may-affects-6.1
/remove-label may-affects-6.2
/remove-label may-affects-6.3
/remove-label may-affects-6.4
/remove-label may-affects-6.5

@woofyzhao
Copy link
Contributor Author

/type improvement

@ti-chi-bot
Copy link
Member

@woofyzhao: The label(s) type/improvement cannot be applied, because the repository doesn't have them.

In response to this:

/type improvement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@woofyzhao
Copy link
Contributor Author

/component doc

@ti-chi-bot
Copy link
Member

@woofyzhao: The label(s) component/doc cannot be applied, because the repository doesn't have them.

In response to this:

/component doc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@woofyzhao
Copy link
Contributor Author

/type bug
/severity minor

@ti-chi-bot ti-chi-bot added type/bug Type: Issue - Confirmed a bug severity/minor labels Jan 10, 2023
@woofyzhao
Copy link
Contributor Author

/remove-type bug
/remove-severity minor
/type enhancement

@ti-chi-bot ti-chi-bot added type/enhancement Type: Issue - Enhancement and removed type/bug Type: Issue - Confirmed a bug severity/minor labels Jan 10, 2023
ti-chi-bot added a commit that referenced this issue Feb 16, 2023
@woofyzhao @ti-chi-bot
Revise CONTRIBUTING.md contents (#14032)
c6aa5e3 
close #14031

Signed-off-by: woofyzhao <490467089@qq.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Type: Issue - Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revise CONTRIBUTING.md contents woofyzhao/tikv
2 participants
@woofyzhao @ti-chi-bot