New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise CONTRIBUTING.md contents #14032
Conversation
Signed-off-by: woofyzhao <490467089@qq.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Welcome @woofyzhao! |
/release-note-none |
/check-issue-triage-complete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: woofyzhao <490467089@qq.com>
@@ -19,6 +19,7 @@ To build TiKV you'll need to at least have the following installed: | |||
* `make` - Build tool (run common workflows) | |||
* `cmake` - Build tool (required for gRPC) | |||
* `awk` - Pattern scanning/processing language | |||
* [`protoc`](https://github.com/protocolbuffers/protobuf/releases) - Google protocol buffer compiler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have drop the dependency long time ago, I believe it's introduced back because of etcd-client. /cc @YuJuncen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, more preciously it is prost
that brings this requirement. After PD exposing some of the operations over the etcd key space in pdpb
, I guess we would be able to remove the requirement of etcd soon.
/cc @YuJuncen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Sorry for the delay...)
/merge |
@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: c064693
|
@woofyzhao: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: woofyzhao 490467089@qq.com
Issue Number: close #14031
What's Changed:
Release note
NONE