Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise CONTRIBUTING.md contents #14032

Merged
merged 5 commits into from Feb 16, 2023
Merged

Revise CONTRIBUTING.md contents #14032

merged 5 commits into from Feb 16, 2023

Conversation

woofyzhao
Copy link
Contributor

@woofyzhao woofyzhao commented Jan 10, 2023

Signed-off-by: woofyzhao 490467089@qq.com

Issue Number: close #14031

What's Changed:

  • Explicitly mention protoc as one of the prerequisites to build tikv in doc.
  • Fix some typo in doc.
  • Fix dead hyper links.

Release note
NONE

Signed-off-by: woofyzhao <490467089@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 10, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen
  • zz-jason

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Welcome @woofyzhao!

It looks like this is your first PR to tikv/tikv 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to tikv/tikv. 😃

@woofyzhao
Copy link
Contributor Author

/release-note-none

@woofyzhao
Copy link
Contributor Author

/check-issue-triage-complete

@woofyzhao
Copy link
Contributor Author

/cc @3pointer
/cc @BusyJay
/cc @zz-jason

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Jan 10, 2023
Signed-off-by: woofyzhao <490467089@qq.com>
@@ -19,6 +19,7 @@ To build TiKV you'll need to at least have the following installed:
* `make` - Build tool (run common workflows)
* `cmake` - Build tool (required for gRPC)
* `awk` - Pattern scanning/processing language
* [`protoc`](https://github.com/protocolbuffers/protobuf/releases) - Google protocol buffer compiler
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have drop the dependency long time ago, I believe it's introduced back because of etcd-client. /cc @YuJuncen

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, more preciously it is prost that brings this requirement. After PD exposing some of the operations over the etcd key space in pdpb, I guess we would be able to remove the requirement of etcd soon.

@woofyzhao
Copy link
Contributor Author

/cc @YuJuncen

Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Sorry for the delay...)

@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Feb 14, 2023
@woofyzhao woofyzhao requested review from BusyJay and removed request for 3pointer February 15, 2023 03:47
@BusyJay
Copy link
Member

BusyJay commented Feb 16, 2023

/merge

@ti-chi-bot
Copy link
Member

@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c064693

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Feb 16, 2023
@ti-chi-bot
Copy link
Member

@woofyzhao: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit c6aa5e3 into tikv:master Feb 16, 2023
@ti-chi-bot ti-chi-bot added this to the Pool milestone Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Type: PR - From contributors first-time-contributor release-note-none size/XS status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise CONTRIBUTING.md contents.
5 participants