Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sst_importer: file may not be rewritten properly while repeating restoration #15483

Closed
YuJuncen opened this issue Aug 31, 2023 · 0 comments · Fixed by #15502
Closed

sst_importer: file may not be rewritten properly while repeating restoration #15483

YuJuncen opened this issue Aug 31, 2023 · 0 comments · Fixed by #15502
Labels
affects-6.5 affects-7.1 component/backup-restore Component: backup, import, external_storage severity/moderate type/bug The issue is confirmed as a bug.

Comments

@YuJuncen
Copy link
Contributor

Bug Report

What version of TiKV are you using?

v6.5.4

What operating system and CPU are you using?

Linux, x86_64.

Steps to reproduce

  1. Restore point to a new cluster.
  2. Drop the tables restored.
  3. In 60 seconds, rerun the restore.

What did you expect?

Restore success and get the same result as the initial restore.

What did happened?

Some of data lost.
@YuJuncen YuJuncen added the type/bug The issue is confirmed as a bug. label Aug 31, 2023
@YuJuncen YuJuncen changed the title sst_importer: file may not be rewritten properly while sst_importer: file may not be rewritten properly while repeating restoration Aug 31, 2023
@YuJuncen YuJuncen mentioned this issue Sep 1, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Sep 12, 2023
@YuJuncen @3pointer
sst_importer: don't cache rewritten files (#15502)
6f0d84e 
close #15483

The rewrite step of sst_importer::apply has been delayed to while iterating the file.

Signed-off-by: hillium <yujuncen@pingcap.com>

Co-authored-by: 3pointer <luancheng@pingcap.com>
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Sep 12, 2023
@YuJuncen @ti-chi-bot
This is an automated cherry-pick of tikv#15502
01350f7 
close tikv#15483

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Sep 12, 2023
Merged
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Sep 12, 2023
@YuJuncen @ti-chi-bot
This is an automated cherry-pick of tikv#15502
133b652 
close tikv#15483

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
YuJuncen added a commit to ti-chi-bot/tikv that referenced this issue Sep 12, 2023
@YuJuncen @3pointer
sst_importer: don't cache rewritten files (tikv#15502)
4dc9577 
close tikv#15483

The rewrite step of sst_importer::apply has been delayed to while iterating the file.

Signed-off-by: hillium <yujuncen@pingcap.com>

Co-authored-by: 3pointer <luancheng@pingcap.com>
ti-chi-bot bot added a commit that referenced this issue Sep 21, 2023
@ti-chi-bot @YuJuncen
@ti-chi-bot @3pointer
sst_importer: don't cache rewritten files (#15502) (#15569)
8d5ca1d 
close #15483

The rewrite step of sst_importer::apply has been delayed to while iterating the file.

Signed-off-by: hillium <yujuncen@pingcap.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Co-authored-by: 3pointer <luancheng@pingcap.com>
ti-chi-bot bot added a commit that referenced this issue Oct 13, 2023
@ti-chi-bot @YuJuncen @ti-chi-bot
sst_importer: don't cache rewritten files (#15502) (#15570)
de7d25b 
close #15483

The rewrite step of sst_importer::apply has been delayed to while iterating the file.

Signed-off-by: hillium <yujuncen@pingcap.com>

Co-authored-by: hillium <yujuncen@pingcap.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
mittalrishabh pushed a commit to mittalrishabh/tikv that referenced this issue May 8, 2024
@ti-chi-bot @YuJuncen
@ti-chi-bot @3pointer
Cherrypick lightning fixes for BR (tikv#5)
55e8755 
* sst_importer: don't cache rewritten files (tikv#15502) (tikv#15569)

close tikv#15483

The rewrite step of sst_importer::apply has been delayed to while iterating the file.

Signed-off-by: hillium <yujuncen@pingcap.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Co-authored-by: 3pointer <luancheng@pingcap.com>

* sst_importer: impl SuspendImport interface (tikv#15612) (tikv#15710)

close tikv#15611

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: hillium <yujuncen@pingcap.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: hillium <yujuncen@pingcap.com>
Co-authored-by: 3pointer <luancheng@pingcap.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Co-authored-by: 3pointer <luancheng@pingcap.com>
Co-authored-by: hillium <yujuncen@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 affects-7.1 component/backup-restore Component: backup, import, external_storage severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sst_importer: don't cache rewritten files YuJuncen/tikv
1 participant
@YuJuncen