Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disk_snapshot_backup: The lag between taking snapshot will slow down the restoration #16518

Closed
YuJuncen opened this issue Feb 9, 2024 · 0 comments · Fixed by #16519
Closed

disk_snapshot_backup: The lag between taking snapshot will slow down the restoration #16518

YuJuncen opened this issue Feb 9, 2024 · 0 comments · Fixed by #16519
Labels
affects-6.5 affects-7.1 affects-7.5 component/backup-restore Component: backup, import, external_storage severity/major type/bug Type: Issue - Confirmed a bug

Comments

@YuJuncen
Copy link
Contributor

YuJuncen commented Feb 9, 2024

Bug Report

What version of TiKV are you using?

v6.5, but this problem applies to master.

What operating system and CPU are you using?

N/A

Steps to reproduce

Backup with EBS snapshot, but delay taking snapshot of some regions about 30 secs ~ 1 min.
Then restore the backup.

What did you expect?

There shouldn't be some regression for restoring.

What did happened?

The restoration is significantly slow down.
@YuJuncen YuJuncen added the type/bug Type: Issue - Confirmed a bug label Feb 9, 2024
@YuJuncen YuJuncen mentioned this issue Feb 9, 2024
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this issue Feb 9, 2024
@YuJuncen
disk_snapshot_backup: pause raft log GC while backing up (#16519)
55c572a 
close #16518

This PR will pause the `CompactLog` admin command during backing up.

Signed-off-by: Yu Juncen <yu745514916@live.com>
@ti-chi-bot ti-chi-bot mentioned this issue Feb 9, 2024
Merged
9 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Feb 9, 2024
@YuJuncen @ti-chi-bot
This is an automated cherry-pick of tikv#16519
21f54e7 
close tikv#16518

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Feb 9, 2024
Open
9 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Feb 9, 2024
@YuJuncen @ti-chi-bot
This is an automated cherry-pick of tikv#16519
afd792d 
close tikv#16518

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Feb 9, 2024
Closed
9 tasks
ti-chi-bot bot pushed a commit that referenced this issue Feb 12, 2024
@ti-chi-bot @YuJuncen
disk_snapshot_backup: pause raft log GC while backing up (#16519) (#1…
b0b048c 
…6520)

close #16518

This PR will pause the `CompactLog` admin command during backing up.

Signed-off-by: Yu Juncen <yu745514916@live.com>

Co-authored-by: Yu Juncen <yu745514916@live.com>
@jebter jebter added the component/backup-restore Component: backup, import, external_storage label Feb 20, 2024
YuJuncen added a commit to ti-chi-bot/tikv that referenced this issue Feb 20, 2024
@YuJuncen
disk_snapshot_backup: pause raft log GC while backing up (tikv#16519)
c66c698 
close tikv#16518

This PR will pause the `CompactLog` admin command during backing up.

Signed-off-by: Yu Juncen <yu745514916@live.com>
dbsid pushed a commit to dbsid/tikv that referenced this issue Mar 24, 2024
@YuJuncen @dbsid
disk_snapshot_backup: pause raft log GC while backing up (tikv#16519)
5d7573e 
close tikv#16518

This PR will pause the `CompactLog` admin command during backing up.

Signed-off-by: Yu Juncen <yu745514916@live.com>
Signed-off-by: dbsid <chenhuansheng@pingcap.com>
mittalrishabh pushed a commit to mittalrishabh/tikv that referenced this issue May 8, 2024
@YuJuncen
disk_snapshot_backup: pause raft log GC while backing up (tikv#16519) (…
4c27334 
…tikv#15)

close tikv#16518

This PR will pause the `CompactLog` admin command during backing up.

Signed-off-by: Yu Juncen <yu745514916@live.com>
Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 affects-7.1 affects-7.5 component/backup-restore Component: backup, import, external_storage severity/major type/bug Type: Issue - Confirmed a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

disk_snapshot_backup: pause raft log GC while backing up YuJuncen/tikv
2 participants
@jebter @YuJuncen