New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disk_snapshot_backup: pause raft log GC while backing up (#16519) #16521
base: release-7.1
Are you sure you want to change the base?
disk_snapshot_backup: pause raft log GC while backing up (#16519) #16521
Conversation
close tikv#16518 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #16519
What is changed and how it works?
Issue Number: Close #16518
What's Changed:
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
The code change is small but the impact would be relatively huge.
We have tested this before which shows there wouldn't be snapshot sent during restoring.
We have disabled GC manually for minutes and see there isn't huge impact to TP workloads (But I guess not for every scenario.).
Side effects
Release note