Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce trivial async block to reduce future size and save memory usage. #16540

Closed
Tracked by #16375
overvenus opened this issue Feb 20, 2024 · 0 comments · Fixed by #16541
Closed
Tracked by #16375

Reduce trivial async block to reduce future size and save memory usage. #16540

overvenus opened this issue Feb 20, 2024 · 0 comments · Fixed by #16541
Labels
affects-6.5 affects-7.1 affects-7.5 type/enhancement Type: Issue - Enhancement

Comments

@overvenus
Copy link
Member

overvenus commented Feb 20, 2024 •
edited

See more: rust#59087
@overvenus overvenus mentioned this issue Feb 20, 2024
Open
15 tasks
@overvenus overvenus added the type/enhancement Type: Issue - Enhancement label Feb 20, 2024
@overvenus overvenus mentioned this issue Feb 20, 2024
Merged
2 tasks
ti-chi-bot bot added a commit that referenced this issue Feb 21, 2024
@overvenus @ti-chi-bot
*: remove unnecessary async blocks to save memory (#16541)
66847e9 
close #16540

*: enable linters about async and futures
  We should be pedantic about writing async code, as it's easy to write
  suboptimal or even bloat code.
  See: rust-lang/rust#69826

*: remove unnecessary async blocks to save memory
  This commit favors FutureExt::map over async blocks to mitigate
  the issue of async block doubled memory usage. Through the sysbench
  oltp_read_only test, it was observed that this adjustment resulted
  in approximately 26% reduction in memory usage.
  See: rust-lang/rust#59087

Signed-off-by: Neil Shen <overvenus@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Mar 13, 2024
@overvenus @ti-chi-bot
This is an automated cherry-pick of tikv#16541
5d44a3a 
close tikv#16540

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Mar 13, 2024
Merged
2 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Mar 18, 2024
@overvenus @ti-chi-bot
This is an automated cherry-pick of tikv#16541
dfe6215 
close tikv#16540

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Mar 18, 2024
Closed
2 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Mar 18, 2024
@overvenus @ti-chi-bot
This is an automated cherry-pick of tikv#16541
6d388a1 
close tikv#16540

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Mar 18, 2024
Closed
2 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Mar 18, 2024
@overvenus @ti-chi-bot
This is an automated cherry-pick of tikv#16541
7fb85e2 
close tikv#16540

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Mar 18, 2024
Open
2 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Mar 18, 2024
@overvenus @ti-chi-bot
This is an automated cherry-pick of tikv#16541
ca12f11 
close tikv#16540

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Mar 18, 2024
Closed
2 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Mar 18, 2024
@overvenus @ti-chi-bot
This is an automated cherry-pick of tikv#16541
ce96641 
close tikv#16540

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Mar 18, 2024
Open
2 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Mar 18, 2024
@overvenus @ti-chi-bot
This is an automated cherry-pick of tikv#16541
81bea72 
close tikv#16540

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Mar 18, 2024
Closed
2 tasks
ti-chi-bot bot pushed a commit that referenced this issue Mar 18, 2024
@ti-chi-bot @overvenus
*: remove unnecessary async blocks to save memory (#16541) (#16644)
a3c827b 
close #16540

*: enable linters about async and futures
  We should be pedantic about writing async code, as it's easy to write
  suboptimal or even bloat code.
  See: rust-lang/rust#69826

*: remove unnecessary async blocks to save memory
  This commit favors FutureExt::map over async blocks to mitigate
  the issue of async block doubled memory usage. Through the sysbench
  oltp_read_only test, it was observed that this adjustment resulted
  in approximately 26% reduction in memory usage.
  See: rust-lang/rust#59087

Signed-off-by: Neil Shen <overvenus@gmail.com>

Co-authored-by: Neil Shen <overvenus@gmail.com>
dbsid pushed a commit to dbsid/tikv that referenced this issue Mar 24, 2024
@overvenus @ti-chi-bot @dbsid
*: remove unnecessary async blocks to save memory (tikv#16541)
55b3a52 
close tikv#16540

*: enable linters about async and futures
  We should be pedantic about writing async code, as it's easy to write
  suboptimal or even bloat code.
  See: rust-lang/rust#69826

*: remove unnecessary async blocks to save memory
  This commit favors FutureExt::map over async blocks to mitigate
  the issue of async block doubled memory usage. Through the sysbench
  oltp_read_only test, it was observed that this adjustment resulted
  in approximately 26% reduction in memory usage.
  See: rust-lang/rust#59087

Signed-off-by: Neil Shen <overvenus@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: dbsid <chenhuansheng@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 affects-7.1 affects-7.5 type/enhancement Type: Issue - Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: remove unnecessary async blocks to save memory overvenus/tikv
2 participants
@overvenus @ti-chi-bot