Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove unnecessary async blocks to save memory (#16541) #16669

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #16541

What is changed and how it works?

Issue Number: Close #16540

Cc #16234

What's Changed:

*: enable linters about async and futures
  We should be pedantic about writing async code, as it's easy to write
  suboptimal or even bloat code.
  See: https://github.com/rust-lang/rust/issues/69826

*: remove unnecessary async blocks to save memory
  This commit favors FutureExt::map over async blocks to mitigate
  the issue of async block doubled memory usage. Through the sysbench
  oltp_read_only test, it was observed that this adjustment resulted
  in approximately 26% reduction in memory usage.
  See: https://github.com/rust-lang/rust/issues/59087

Check List

Tests

  • Unit test
  • Manual test

Run sysbench oltp_read_only on a single-node tikv cluster.

Configs and test commands

TiKV config:

[readpool]
[readpool.unified]
# Unlimited concurrent running tasks.
max-tasks-per-worker = 1000000000

Injects a fail points to TiKV so that all tasks on read pool are blocked.

TiDB config:

# Do not limit concurrent transcations.
token-limit = 100000000
[txn-local-latches]
enabled = false

Sysbench command:

while true; do { \
    sysbench --db-driver=mysql --mysql-host=10.2.12.86 --mysql-port=31825 --mysql-user=root \
        --mysql-db=test1 --tables=1 --table-size=100000000 --create_secondary=false \
        --time=5 --skip_trx=true --range_selects=false  --threads=1000 ./oltp_read_only run & \
    pid=$!; sleep 8; kill $pid; \
} done

Test results:

Nightly vs This PR
4.47GB vs 3.28GB
image

Release note

None

Copy link
Contributor

ti-chi-bot bot commented Mar 18, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

This commit favors FutureExt::map over async blocks to mitigate
the issue of async block doubled memory usage. Through the sysbench
oltp_read_only test, it was observed that this adjustment resulted
in approximately 26% reduction in memory usage.

See: rust-lang/rust#59087

Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus force-pushed the cherry-pick-16541-to-release-7.5 branch from ce96641 to a9fc87d Compare May 22, 2024 03:10
@ti-chi-bot ti-chi-bot bot added size/M and removed size/XL labels May 22, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label May 22, 2024
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels May 22, 2024
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented May 22, 2024

@overvenus: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 22, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 03dd055

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label May 22, 2024
Copy link
Contributor

ti-chi-bot bot commented May 22, 2024

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 0df42b7 into tikv:release-7.5 May 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none size/M status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals type/cherry-pick-for-release-7.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants