Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Update sysinfo dependency #13385

Merged
merged 2 commits into from Dec 7, 2022
Merged

*: Update sysinfo dependency #13385

merged 2 commits into from Dec 7, 2022

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Aug 31, 2022

What is changed and how it works?

Issue Number: ref #11276

What's Changed:

Update sysinfo dependency from 0.16.4 to 0.26.5

Check List

Tests

  • No code

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 31, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • BusyJay
  • hicqu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Welcome @dveeden!

It looks like this is your first PR to tikv/tikv 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to tikv/tikv. 😃

@dveeden
Copy link
Contributor Author

dveeden commented Sep 2, 2022

/cc @BusyJay @hicqu

@BusyJay
Copy link
Member

BusyJay commented Sep 16, 2022

I can see there are several PRs that tries to update dependencies. How about also include those changes in this PR?

https://github.com/tikv/tikv/pulls/app%2Fdependabot

@dveeden
Copy link
Contributor Author

dveeden commented Sep 16, 2022

@BusyJay I prefer to handle these in separate PRs to limit the scope and the number of changes per PR

@dveeden
Copy link
Contributor Author

dveeden commented Oct 18, 2022

PTAL @BusyJay

@ti-chi-bot ti-chi-bot added size/L and removed size/M labels Oct 18, 2022
@dveeden dveeden force-pushed the sysinfo branch 2 times, most recently from 92f9e95 to 155598d Compare October 18, 2022 20:39
@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Nov 29, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Nov 29, 2022
@dveeden
Copy link
Contributor Author

dveeden commented Nov 29, 2022

/assign @BusyJay @hicqu

Signed-off-by: Daniël van Eeden <git@myname.nl>
@BusyJay
Copy link
Member

BusyJay commented Dec 6, 2022

/merge

@ti-chi-bot
Copy link
Member

@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eb03e66

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Dec 6, 2022
@ti-chi-bot
Copy link
Member

@dveeden: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 044aa15 into tikv:master Dec 7, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Type: PR - From contributors first-time-contributor release-note-none size/M status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants