Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raftstore-v2: support apply snapshot #13734

Merged
merged 24 commits into from
Nov 25, 2022
Merged

raftstore-v2: support apply snapshot #13734

merged 24 commits into from
Nov 25, 2022

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Nov 3, 2022 •
edited
Loading

What is changed and how it works?

Issue Number: Ref #12842

What's Changed:

aftstore-v2: support apply snapshot
This PR implementation apply snapshot relative changes.
- add snap worker for multi-rocksdb

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 3, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • BusyJay
  • tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 3, 2022
@bufferflies bufferflies force-pushed the apply_task branch 3 times, most recently from 0ecf55f to ee8d44a Compare November 7, 2022 06:13
@bufferflies
init
efc1153 
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 8, 2022
@bufferflies
path
f6065fe 
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies
path
9c597fa 
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies
apply_task
2443703 
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies
path
f278de8 
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies
apply task
4bd7f12 
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies bufferflies marked this pull request as ready for review November 10, 2022 02:46
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2022
@bufferflies
Copy link
Contributor Author

/cc @BusyJay @nolouch @tonyxuqqi

@bufferflies
rename snap
17e7901 
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies
set last term before load tablet
46b3a93 
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2022
@bufferflies
remote msg append by raft tick
03dab3a 
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies
update master
8506260 
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2022
@bufferflies
apply task
a2a08d8 
Signed-off-by: bufferflies <1045931706@qq.com>
@nolouch
Copy link
Contributor

nolouch commented Nov 22, 2022

ci failed @bufferflies

@bufferflies
pass unit test
5dcecfd 
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies
panic if snapshot path load tablet failed
14bf4b1 
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 23, 2022
@nolouch
Copy link
Contributor

nolouch commented Nov 23, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@nolouch: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2022
@bufferflies
update master
458edf8 
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2022
@AndreMouche
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@AndreMouche: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 458edf8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2022
@ti-chi-bot ti-chi-bot merged commit 998cb30 into tikv:master Nov 25, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Nov 25, 2022
@bufferflies bufferflies deleted the apply_task branch November 25, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch left review comments

@tabokie tabokie tabokie left review comments

@AndreMouche AndreMouche AndreMouche approved these changes

@BusyJay BusyJay BusyJay approved these changes

@tonyxuqqi tonyxuqqi tonyxuqqi approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.
7 participants
@bufferflies @ti-chi-bot @nolouch @AndreMouche @BusyJay @tonyxuqqi @tabokie