PITR: support modifying the config tikv.import.memory-use-ratio online when restore point.

[joccau]

What is changed and how it works?

Issue Number: Close #14409

What's Changed:
As title.

Related changes

• PR to update pingcap/docs/pingcap/docs-cn:
• Need to cherry-pick to the release branch

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Manual test

MySQL [(none)]> show config where type='tikv' and name='import.memory-use-ratio';
+------+-----------------+-------------------------+-------+
| Type | Instance        | Name                    | Value |
+------+-----------------+-------------------------+-------+
| tikv | 10.2.5.31:20162 | import.memory-use-ratio | 0.3   |
| tikv | 10.2.5.11:20160 | import.memory-use-ratio | 0.3   |
| tikv | 10.2.5.18:20161 | import.memory-use-ratio | 0.3   |
+------+-----------------+-------------------------+-------+


MySQL [(none)]> set config tikv `import.memory-use-ratio`=0.1;
MySQL [(none)]> show config where type='tikv' and name='import.memory-use-ratio';
+------+-----------------+-------------------------+-------+
| Type | Instance        | Name                    | Value |
+------+-----------------+-------------------------+-------+
| tikv | 10.2.5.31:20162 | import.memory-use-ratio | 0.1   |
| tikv | 10.2.5.11:20160 | import.memory-use-ratio | 0.1   |
| tikv | 10.2.5.18:20161 | import.memory-use-ratio | 0.1   |
+------+-----------------+-------------------------+-------+


MySQL [(none)]> set config tikv `import.memory-use-ratio`=0.2;
MySQL [(none)]> show config where type='tikv' and name='import.memory-use-ratio';
+------+-----------------+-------------------------+-------+
| Type | Instance        | Name                    | Value |
+------+-----------------+-------------------------+-------+
| tikv | 10.2.5.31:20162 | import.memory-use-ratio | 0.2   |
| tikv | 10.2.5.11:20160 | import.memory-use-ratio | 0.2   |
| tikv | 10.2.5.18:20161 | import.memory-use-ratio | 0.2   |
+------+-----------------+-------------------------+-------+

Find the message from tikv.log

[2023/03/16 19:05:03.608 +08:00] [INFO] [config.rs:76] ["import config changed"] [change="{\"memory_use_ratio\": 0.1}"]
[2023/03/16 19:05:09.598 +08:00] [INFO] [sst_importer.rs:599] ["update importer config"] [size=3435973836] [memory-use-ratio=0.1]

[2023/03/16 19:08:42.187 +08:00] [INFO] [config.rs:76] ["import config changed"] [change="{\"memory_use_ratio\": 0.2}"]
[2023/03/16 19:08:49.801 +08:00] [INFO] [sst_importer.rs:599] ["update importer config"] [size=6871947673] [memory-use-ratio=0.2]

Side effects

• Performance regression
  • Consumes more CPU
  • Consumes more MEM
• Breaking backward compatibility

Release note

Support modify the config tikv.import.memory-use-ratio online when restore point

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• YuJuncen
• overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[YuJuncen]

rest lgtm

[joccau]

/rebuild

[ti-chi-bot]

@Leavrth: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[tonyxuqqi]

It's generally not recommended to use Deref as it's not easy to trace the code, per my understanding.
I think in this case just use self.0.as_ref() directly seems more straightforward.

[tonyxuqqi]

/merge

[ti-chi-bot]

@tonyxuqqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: a6d18a4

[ti-chi-bot]

@joccau: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[joccau]

/retest

[joccau]

/rebuild