raftstore-v2: not update modification index for delete range

[SpadeA-Tang]

What is changed and how it works?

Issue Number: Close #14904

What's Changed:

not update modification index for delete range 

If key range are matched well with sst files, delete range may not produce entries in memtable. It means it is possible that the memtable is empty after delete range for default cf for instance, and there's no further write/delete for default cf, last_modified will never equal to last_flushed for this cf. So, admin flushed index will never be progressed.

As delete range is an usafe operation and cannot be rollbacked to replay, so it's better to not modify the modification index for delete range operation.

Related changes

• PR to update pingcap/docs/pingcap/docs-cn:
• Need to cherry-pick to the release branch

Check List

Tests

• Unit test
• Integration test

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• bufferflies
• overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[tonyxuqqi]

"last_modified will never equal to last_flushed for this cf"

Do you mean this code " fn maybe_advance_admin_flushed(&mut self, mem_index: u64) {
if self.admin.flushed < self.admin.last_modified {
return;
}"

[SpadeA-Tang]

"last_modified will never equal to last_flushed for this cf"

Do you mean this code " fn maybe_advance_admin_flushed(&mut self, mem_index: u64) { if self.admin.flushed < self.admin.last_modified { return; }"

let min_flushed = self
    .data_cfs
    .iter_mut()
    // Only unflushed CFs are considered. Flushed CF always have uptodate changes
    // persisted.
    .filter_map(|pr| {
        // All modifications before mem_index must be seen. If following condition is
        // true, it means the modification comes beyond general apply process (like
        // transaction GC unsafe write). Align `last_modified` to `flushed` to avoid
        // blocking raft log GC.
        if mem_index >= pr.flushed && pr.flushed > pr.last_modified {
            pr.last_modified = pr.flushed;
        }
        if pr.last_modified != pr.flushed {
            Some(pr.flushed)
        } else {
            None
        }
    })
    .min();

[overvenus]

/merge

[ti-chi-bot]

@overvenus: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 7d1d857

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #14933.