raftstore-v2: not update modification index for delete range (#14905) #14933
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #14905
What is changed and how it works?
Issue Number: Close #14904
What's Changed:
If key range are matched well with sst files, delete range may not produce entries in memtable. It means it is possible that the memtable is empty after delete range for default cf for instance, and there's no further write/delete for default cf,
last_modified
will never equal tolast_flushed
for this cf. So, admin flushed index will never be progressed.As delete range is an usafe operation and cannot be rollbacked to replay, so it's better to not modify the modification index for delete range operation.
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Release note