Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore-v2: not update modification index for delete range (#14905) #14933

Closed

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #14905

What is changed and how it works?

Issue Number: Close #14904

What's Changed:

not update modification index for delete range 

If key range are matched well with sst files, delete range may not produce entries in memtable. It means it is possible that the memtable is empty after delete range for default cf for instance, and there's no further write/delete for default cf, last_modified will never equal to last_flushed for this cf. So, admin flushed index will never be progressed.

As delete range is an usafe operation and cannot be rollbacked to replay, so it's better to not modify the modification index for delete range operation.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

None

Signed-off-by: Spade A <u6748471@anu.edu.au>
Signed-off-by: Spade A <u6748471@anu.edu.au>
Signed-off-by: Spade A <u6748471@anu.edu.au>
Signed-off-by: Spade A <u6748471@anu.edu.au>
Signed-off-by: Spade A <u6748471@anu.edu.au>
Signed-off-by: Spade A <u6748471@anu.edu.au>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants