resolved_ts: use smaller timeout when do check_leader #16000

crazycs520 · 2023-11-16T01:53:13Z

What is changed and how it works?

Issue Number: Close #15999

What's Changed:

use smaller timeout when do check_leader, to to reduce the impact of a single TiKV slowing down on the advance resolve_ts of other TiKVs

Related changes

Need to cherry-pick to the release branch

Check List

Tests

Manual test (add detailed scripts or steps below)

Before

This PR

Side effects

N/A

Release note

None.

Signed-off-by: crazycs520 <crazycs520@gmail.com>

ti-chi-bot · 2023-11-16T01:53:16Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

you06
zyguan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

you06 · 2023-11-21T06:24:12Z

/retest

components/resolved_ts/src/advance.rs

Co-authored-by: cfzjywxk <cfzjywxk@gmail.com> Signed-off-by: crazycs <crazycs520@gmail.com>

Signed-off-by: crazycs520 <crazycs520@gmail.com>

components/resolved_ts/src/advance.rs

Signed-off-by: crazycs520 <crazycs520@gmail.com>

LykxSassinator · 2023-12-05T04:09:13Z

Should we also cherry-pick this pr to release-6.5 ?

cfzjywxk · 2023-12-05T04:58:13Z

Should we also cherry-pick this pr to release-6.5 ?

I think so.
/cc @crazycs520 @zyguan

ti-chi-bot · 2023-12-05T04:58:17Z

@cfzjywxk: GitHub didn't allow me to request PR reviews from the following users: crazycs520.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Should we also cherry-pick this pr to release-6.5 ?

I think so.
/cc @crazycs520 @zyguan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Tema · 2024-04-25T01:22:16Z

@cfzjywxk looks like we missed to land it on the master. Could you please help with that and then cherry-pick it into 7.5 so that we can pick it in the next patch release

ti-chi-bot · 2024-04-28T02:52:25Z

In response to a cherrypick label: new pull request created to branch release-7.5: #16928.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

close #15999 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: crazycs520 <crazycs520@gmail.com> Co-authored-by: crazycs <crazycs520@gmail.com> Co-authored-by: crazycs520 <crazycs520@gmail.com>

Tema · 2024-04-29T22:17:04Z

@crazycs520 thanks for cherry-pick into 7.5. It still misses from master, though.

…ikv#16928) close tikv#15999 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: crazycs520 <crazycs520@gmail.com> Co-authored-by: crazycs <crazycs520@gmail.com> Co-authored-by: crazycs520 <crazycs520@gmail.com>

close #15999 Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

…ikv#9) * refine resolve check_leader timeout and add failpoint Signed-off-by: crazycs520 <crazycs520@gmail.com> * fix Signed-off-by: crazycs520 <crazycs520@gmail.com> * remove fail_point Signed-off-by: crazycs520 <crazycs520@gmail.com> * Update components/resolved_ts/src/advance.rs Co-authored-by: cfzjywxk <cfzjywxk@gmail.com> Signed-off-by: crazycs <crazycs520@gmail.com> * make format Signed-off-by: crazycs520 <crazycs520@gmail.com> * add unit test Signed-off-by: crazycs520 <crazycs520@gmail.com> --------- Signed-off-by: crazycs520 <crazycs520@gmail.com> Signed-off-by: crazycs <crazycs520@gmail.com> Co-authored-by: cfzjywxk <cfzjywxk@gmail.com> Signed-off-by: crazycs520 <crazycs520@gmail.com> Signed-off-by: crazycs <crazycs520@gmail.com> Co-authored-by: crazycs <crazycs520@gmail.com> Co-authored-by: cfzjywxk <cfzjywxk@gmail.com>

…ikv#16928) close tikv#15999 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: crazycs520 <crazycs520@gmail.com> Co-authored-by: crazycs <crazycs520@gmail.com> Co-authored-by: crazycs520 <crazycs520@gmail.com>

… (#16990) close #15999 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: crazycs520 <crazycs520@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Co-authored-by: crazycs <crazycs520@gmail.com> Co-authored-by: crazycs520 <crazycs520@gmail.com>

…ikv#16928) close tikv#15999 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: crazycs520 <crazycs520@gmail.com> Co-authored-by: crazycs <crazycs520@gmail.com> Co-authored-by: crazycs520 <crazycs520@gmail.com>

… (#17095) close #15999 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: glorv <glorvs@163.com> Co-authored-by: crazycs <crazycs520@gmail.com> Co-authored-by: glorv <glorvs@163.com>

crazycs520 added 3 commits November 15, 2023 20:48

refine resolve check_leader timeout and add failpoint

68e387c

Signed-off-by: crazycs520 <crazycs520@gmail.com>

fix

948ee94

Signed-off-by: crazycs520 <crazycs520@gmail.com>

remove fail_point

7a610a0

Signed-off-by: crazycs520 <crazycs520@gmail.com>

ti-chi-bot bot added release-note-none contribution Type: PR - From contributors size/M labels Nov 16, 2023

you06 approved these changes Nov 21, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Nov 21, 2023

zyguan approved these changes Nov 21, 2023

View reviewed changes

components/resolved_ts/src/advance.rs Show resolved Hide resolved

ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Nov 21, 2023

cfzjywxk reviewed Nov 22, 2023

View reviewed changes

components/resolved_ts/src/advance.rs Outdated Show resolved Hide resolved

crazycs520 and others added 2 commits November 22, 2023 16:06

Update components/resolved_ts/src/advance.rs

fb0f60e

Co-authored-by: cfzjywxk <cfzjywxk@gmail.com> Signed-off-by: crazycs <crazycs520@gmail.com>

make format

e098508

Signed-off-by: crazycs520 <crazycs520@gmail.com>

cfzjywxk reviewed Nov 22, 2023

View reviewed changes

components/resolved_ts/src/advance.rs Show resolved Hide resolved

add unit test

73554c6

Signed-off-by: crazycs520 <crazycs520@gmail.com>

cfzjywxk merged commit cc242e2 into tikv:tikv-6.5-with-kv-timeout-feature Nov 24, 2023
2 of 3 checks passed

ti-chi-bot bot requested a review from zyguan December 5, 2023 04:58

cfzjywxk added the needs-cherry-pick-release-7.5 label Apr 28, 2024

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Apr 28, 2024

This is an automated cherry-pick of tikv#16000

d3f5d86

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Apr 28, 2024

resolved_ts: use smaller timeout when do check_leader (#16000) #16928

Merged

crazycs520 mentioned this pull request May 6, 2024

resolved_ts: use smaller timeout when do check_leader (#16000) #16943

Merged

ti-chi-bot bot added a commit that referenced this pull request May 8, 2024

resolved_ts: use smaller timeout when do check_leader (#16000) (#16943)

e106c8d

close #15999 Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

ti-chi-bot mentioned this pull request May 9, 2024

resolved_ts: use smaller timeout when do check_leader (#16000) (#16943) #16990

Merged

This was referenced Jun 4, 2024

resolved_ts: use smaller timeout when do check_leader (#16000) (#16943) #17094

Open

resolved_ts: use smaller timeout when do check_leader (#16000) (#16943) #17095

Merged

ti-chi-bot bot mentioned this pull request Jun 26, 2024

[DNM] Fips debug #16441

Open

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resolved_ts: use smaller timeout when do check_leader #16000

resolved_ts: use smaller timeout when do check_leader #16000

crazycs520 commented Nov 16, 2023 •

edited

Loading

ti-chi-bot bot commented Nov 16, 2023 •

edited

Loading

you06 commented Nov 21, 2023

LykxSassinator commented Dec 5, 2023

cfzjywxk commented Dec 5, 2023

ti-chi-bot bot commented Dec 5, 2023

Tema commented Apr 25, 2024

ti-chi-bot commented Apr 28, 2024

Tema commented Apr 29, 2024

resolved_ts: use smaller timeout when do check_leader #16000

resolved_ts: use smaller timeout when do check_leader #16000

Conversation

crazycs520 commented Nov 16, 2023 • edited Loading

What is changed and how it works?

Related changes

Check List

Release note

ti-chi-bot bot commented Nov 16, 2023 • edited Loading

you06 commented Nov 21, 2023

LykxSassinator commented Dec 5, 2023

cfzjywxk commented Dec 5, 2023

ti-chi-bot bot commented Dec 5, 2023

Tema commented Apr 25, 2024

ti-chi-bot commented Apr 28, 2024

Tema commented Apr 29, 2024

crazycs520 commented Nov 16, 2023 •

edited

Loading

ti-chi-bot bot commented Nov 16, 2023 •

edited

Loading