Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolved_ts: use smaller timeout when do check_leader (#16000) #16943

Merged
merged 5 commits into from
May 8, 2024

Conversation

crazycs520
Copy link
Contributor

This is a cherry-pick of #16000

What is changed and how it works?

Issue Number: Close #15999

What's Changed:

  • use smaller timeout when do check_leader, to to reduce the impact of a single TiKV slowing down on the advance resolve_ts of other TiKVs

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Before

image

image

This PR

image

image

Side effects

  • N/A

Release note

None.

…ikv#16928)

close tikv#15999

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: crazycs520 <crazycs520@gmail.com>

Co-authored-by: crazycs <crazycs520@gmail.com>
Co-authored-by: crazycs520 <crazycs520@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented May 6, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • MyonKeminta
  • cfzjywxk

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none contribution Type: PR - From contributors labels May 6, 2024
Copy link
Contributor

ti-chi-bot bot commented May 6, 2024

Hi @crazycs520. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label May 6, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels May 6, 2024
@cfzjywxk
Copy link
Collaborator

cfzjywxk commented May 6, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented May 6, 2024

@cfzjywxk: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 6, 2024

This pull request has been accepted and is ready to merge.

Commit hash: c57ca9e

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label May 6, 2024
Copy link
Contributor

ti-chi-bot bot commented May 8, 2024

@crazycs520: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@cfzjywxk
Copy link
Collaborator

cfzjywxk commented May 8, 2024

/test

Copy link
Contributor

ti-chi-bot bot commented May 8, 2024

@cfzjywxk: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-unit-test

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cfzjywxk
Copy link
Collaborator

cfzjywxk commented May 8, 2024

/test all

@ti-chi-bot ti-chi-bot bot merged commit e106c8d into tikv:master May 8, 2024
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #16990.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against tikv/tikv#release-7.5 from head ti-chi-bot:cherry-pick-16943-to-release-7.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between tikv:release-7.5 and ti-chi-bot:cherry-pick-16943-to-release-7.5"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

ti-chi-bot bot added a commit that referenced this pull request May 15, 2024
… (#16990)

close #15999

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: crazycs520 <crazycs520@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Co-authored-by: crazycs <crazycs520@gmail.com>
Co-authored-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #17094.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #17095.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Jun 4, 2024
close tikv#15999

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Jun 4, 2024
… (#17095)

close #15999

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: glorv <glorvs@163.com>

Co-authored-by: crazycs <crazycs520@gmail.com>
Co-authored-by: glorv <glorvs@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 store check_leader slow may affect may store to advance resolve_ts
5 participants