Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: update apply state even if peer is removed (#16060) #16084

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #16060

What is changed and how it works?

Issue Number: Close #16069

Also close pingcap/tidb#48802

What's Changed:

When a peer is removed, it is necessary to update its apply state because
this peer may be simultaneously taking a snapshot. An outdated apply state
will invalidate the coprocessor cache assumption and potentially lead to
a violation of linearizability (returning stale cache).

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note

Fix an issue that TiKV coprocessor may return stale data when a raft peer is removed

close tikv#16069, close pingcap/tidb#48802

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Copy link
Contributor

ti-chi-bot bot commented Nov 27, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member Author

This pull request is closed because its related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

https://prow.tidb.net/command-help#cherrypick
https://book.prow.tidb.net/#/plugins/cherrypicker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-5.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants