Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: Add slow log for peer and store msg (#16605) #17035

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #16605

What is changed and how it works?

Issue Number: Ref #16600

What's Changed:

Add slow log for peer and store msg

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Add slow log for peer and store msg

ref tikv#16600

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Copy link
Contributor

ti-chi-bot bot commented May 21, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@wuhuizuo
Copy link
Contributor

/assign Connor1996

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label May 28, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels May 28, 2024
@glorv
Copy link
Contributor

glorv commented May 28, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented May 28, 2024

@glorv: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 28, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 9737e2a

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label May 28, 2024
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996 Connor1996 force-pushed the cherry-pick-16605-to-release-7.5 branch from 4818976 to 5853c17 Compare May 28, 2024 09:17
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Status: Can merge to base branch label May 28, 2024
@Connor1996
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented May 28, 2024

@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 28, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 5853c17

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label May 28, 2024
Copy link
Contributor

ti-chi-bot bot commented May 28, 2024

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 1a2c88d into tikv:release-7.5 May 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note size/L status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals type/cherry-pick-for-release-7.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants