New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: remove stale peer as soon as possible #2281

Merged
merged 5 commits into from Sep 13, 2017

Conversation

Projects
None yet
3 participants
@BusyJay
Contributor

BusyJay commented Sep 11, 2017

When a peer is applying snapshot, it won't have any tasks in apply worker, hence it's safe to destroy it immediately.

We need fail point support to write a stable tests.

raftstore: remove stale peer as soon as possible
When a peer is applying snapshot, it won't have any tasks in apply
worker, hence it's safe to destroy it immediately.
@lishuai87

This comment has been minimized.

Show comment
Hide comment
@lishuai87

lishuai87 Sep 12, 2017

Contributor

LGTM

Contributor

lishuai87 commented Sep 12, 2017

LGTM

@BusyJay BusyJay requested a review from huachaohuang Sep 12, 2017

Some(p) => if p.peer_id() == peer.get_id() {
p
} else {
assert!(p.peer_id() > peer.get_id());

This comment has been minimized.

@siddontang

siddontang Sep 12, 2017

Contributor

add a comment for how can we meet this case.

@siddontang

siddontang Sep 12, 2017

Contributor

add a comment for how can we meet this case.

@siddontang

Rest LGTM

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 13, 2017

Contributor

/run-all-tests

Contributor

BusyJay commented Sep 13, 2017

/run-all-tests

@siddontang siddontang merged commit 05f0362 into master Sep 13, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@ngaut ngaut deleted the busyjay/destroy-stale branch Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment