raftstore: remove stale peer as soon as possible #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a peer is applying snapshot, it won't have any tasks in apply worker, hence it's safe to destroy it immediately.
siddontang
reviewed
Sep 11, 2017
src/raftstore/store/store.rs
Outdated
| Some(p) => if p.peer_id() == peer.get_id() { | ||
| p | ||
| } else { | ||
| // It has been destroyed. |
There was a problem hiding this comment.
need to check p.peer_id() must > peer.get_id() here?
|
LGTM |
lishuai87
approved these changes
Sep 12, 2017
siddontang
reviewed
Sep 12, 2017
| Some(p) => if p.peer_id() == peer.get_id() { | ||
| p | ||
| } else { | ||
| assert!(p.peer_id() > peer.get_id()); |
There was a problem hiding this comment.
add a comment for how can we meet this case.
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a peer is applying snapshot, it won't have any tasks in apply worker, hence it's safe to destroy it immediately.
We need fail point support to write a stable tests.