expression: add builtin truncate_decimal #3637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: niedhui <niedhui@gmail.com>
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
|
Thx. LGTM. |
solotzg
reviewed
Sep 28, 2018
ice1000
added
sig/coprocessor
Signed-off-by: niedhui <niedhui@gmail.com>
solotzg
previously approved these changes
Sep 30, 2018
Signed-off-by: niedhui <niedhui@gmail.com>
solotzg
previously approved these changes
Sep 30, 2018
|
@crazycs520 PTAL |
|
@niedhui please help to resolve conflicts. Thanks. |
breezewish
added
status/LGT2
…uncate_decimal Signed-off-by: niedhui <niedhui@gmail.com> # Conflicts: # src/coprocessor/dag/expr/scalar_function.rs
|
@solotzg done |
|
@solotzg PTAL |
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
huachaohuang
approved these changes
Oct 12, 2018
solotzg
approved these changes
Oct 12, 2018
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
* expression: add builtin truncate_decimal Signed-off-by: niedhui <niedhui@gmail.com> * more corn cases Signed-off-by: niedhui <niedhui@gmail.com> * fix format issue Signed-off-by: niedhui <niedhui@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: niedhui niedhui@gmail.com
What have you changed? (mandatory)
implement builtin funciton: truncate_real
What are the type of the changes? (mandatory)
Improvement
How has this PR been tested? (mandatory)
unit test
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No
Refer to a related PR or issue link (optional)
#3275