Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: upgrade grpcio to v0.4 (#3650) #3704

Merged
merged 1 commit into from Oct 23, 2018
Merged

*: upgrade grpcio to v0.4 (#3650) #3704

merged 1 commit into from Oct 23, 2018

Conversation

overvenus
Copy link
Member

What have you changed? (mandatory)

Cherry pick #3650 .

@overvenus
*: upgrade grpcio to v0.4 (tikv#3650)
e27dbb8 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus changed the base branch from master to release-2.1 October 23, 2018 08:09
@overvenus overvenus added the type/cherry-pick Type: PR - Cherry pick label Oct 23, 2018
@disksing
Copy link
Contributor

LGTM

siddontang
siddontang approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disksing disksing merged commit 839e4a2 into tikv:release-2.1 Oct 23, 2018
@overvenus overvenus deleted the release-2.1-grpc-0.4 branch October 23, 2018 12:38
overvenus added a commit that referenced this pull request Nov 6, 2018
@overvenus
Revert "*: upgrade grpcio to v0.4 (#3650) (#3704)"
7ed368f 
This reverts commit 839e4a2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddontang siddontang siddontang approved these changes

Assignees
No one assigned
Labels
type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@overvenus @disksing @siddontang