Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.1] cherry-pick: Add end_key limit to kv_scan interface (#3720) #3749

Merged

Conversation

MyonKeminta
Copy link
Contributor

What have you changed? (mandatory)

This PR cherry-picks #3720 to release-2.1 branch.

What are the type of the changes? (mandatory)

  • Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

By CI

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta MyonKeminta force-pushed the misono/cherry-pick-scan-end-key branch from b73be62 to 14530e5 Compare November 7, 2018 04:15
@zhangjinpeng87
Copy link
Member

Please fix conflict.

@MyonKeminta MyonKeminta closed this Nov 8, 2018
@MyonKeminta MyonKeminta reopened this Nov 8, 2018
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hicqu
Copy link
Contributor

hicqu commented Nov 9, 2018

LGTM.

@MyonKeminta
Copy link
Contributor Author

Can this be merged?

@MyonKeminta
Copy link
Contributor Author

@zhangjinpeng1987 PTAL

@zhangjinpeng87 zhangjinpeng87 merged commit 9df2832 into tikv:release-2.1 Nov 10, 2018
@MyonKeminta MyonKeminta deleted the misono/cherry-pick-scan-end-key branch November 12, 2018 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants