Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikvclient: Add endKey param to Scanner (#8178) #8247

Merged
merged 5 commits into from
Nov 12, 2018
Merged

tikvclient: Add endKey param to Scanner (#8178) #8247

merged 5 commits into from
Nov 12, 2018

Conversation

MyonKeminta
Copy link
Contributor

@MyonKeminta MyonKeminta commented Nov 9, 2018 •
edited
Loading

What problem does this PR solve?

This PR cherry-picks #8178 to release-2.1 branch, and needs to be merged after:

What is changed and how it works?

This PR cherry-picks #8178 to release-2.1 branch.

Check List

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has interface methods change

Side effects

Related changes

  • Need to be included in the release note

MyonKeminta and others added 2 commits November 9, 2018 13:33
@MyonKeminta
Update kvproto
73118d3 
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta
tikvclient: Add endKey param to Scanner (pingcap#8178)
f17ec48 
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta MyonKeminta changed the title [Waiting for #8081] [release-2.1] cherry-pick: Fix kv_scan out of bound [release-2.1] cherry-pick: tikvclient: Add endKey param to Scanner (#8178) Nov 9, 2018
@MyonKeminta MyonKeminta changed the title [release-2.1] cherry-pick: tikvclient: Add endKey param to Scanner (#8178) [DNM] [release-2.1] cherry-pick: tikvclient: Add endKey param to Scanner (#8178) Nov 9, 2018
@MyonKeminta MyonKeminta mentioned this pull request Nov 9, 2018
Merged
@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added priority/release-blocker This PR blocks a release. Please review it ASAP. component/tikv type/2.1 cherry-pick status/LGT1 Indicates that a PR has LGTM 1. labels Nov 10, 2018
@zz-jason zz-jason changed the title [DNM] [release-2.1] cherry-pick: tikvclient: Add endKey param to Scanner (#8178) tikvclient: Add endKey param to Scanner (#8178) Nov 10, 2018
@zz-jason
Copy link
Member

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

@MyonKeminta
Copy link
Contributor Author

/run-integration-common-test tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

winkyao
winkyao approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 12, 2018
@zz-jason zz-jason merged commit a3e47ae into pingcap:release-2.1 Nov 12, 2018
@MyonKeminta MyonKeminta deleted the misono/cherry-pick-scan-end-key branch November 12, 2018 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winkyao winkyao winkyao approved these changes

Assignees
No one assigned
Labels
component/tikv priority/release-blocker This PR blocks a release. Please review it ASAP. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MyonKeminta @zz-jason @winkyao