Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikvclient: Add endKey param to Scanner (#8178) #8247

Merged

Conversation

@MyonKeminta
Copy link
Contributor

MyonKeminta commented Nov 9, 2018

What problem does this PR solve?

This PR cherry-picks #8178 to release-2.1 branch, and needs to be merged after:

  • #8246
  • tikv/tikv#3749
    This fixes in some conditions the kv_scan goes to a deleted range, which may make tikv panic.

What is changed and how it works?

This PR cherry-picks #8178 to release-2.1 branch.

Check List

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has interface methods change

Side effects

Related changes

  • Need to be included in the release note
MyonKeminta added 2 commits Nov 9, 2018
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta MyonKeminta changed the title [Waiting for #8081] [release-2.1] cherry-pick: Fix kv_scan out of bound [release-2.1] cherry-pick: tikvclient: Add endKey param to Scanner (#8178) Nov 9, 2018
@MyonKeminta MyonKeminta changed the title [release-2.1] cherry-pick: tikvclient: Add endKey param to Scanner (#8178) [DNM] [release-2.1] cherry-pick: tikvclient: Add endKey param to Scanner (#8178) Nov 9, 2018
@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Nov 10, 2018

LGTM

@zz-jason zz-jason changed the title [DNM] [release-2.1] cherry-pick: tikvclient: Add endKey param to Scanner (#8178) tikvclient: Add endKey param to Scanner (#8178) Nov 10, 2018
@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Nov 10, 2018

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

@MyonKeminta

This comment has been minimized.

Copy link
Contributor Author

MyonKeminta commented Nov 10, 2018

/run-integration-common-test tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

Copy link
Member

winkyao left a comment

LGTM

@zz-jason zz-jason merged commit a3e47ae into pingcap:release-2.1 Nov 12, 2018
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@MyonKeminta MyonKeminta deleted the MyonKeminta:misono/cherry-pick-scan-end-key branch Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.