Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copr: Add week_day and week_of_year #3871

Merged
merged 4 commits into from
Dec 4, 2018
Merged

Copr: Add week_day and week_of_year #3871

merged 4 commits into from
Dec 4, 2018

Conversation

koushiro
Copy link
Contributor

@koushiro koushiro commented Dec 3, 2018

Signed-off-by: koushiro koushiro.cqx@gmail.com

What have you changed? (mandatory)

Implement builtin function: week_day and week_of_year

What are the type of the changes? (mandatory)

  • Improvement

How has this PR been tested? (mandatory)

unit test

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

no

Does this PR affect tidb-ansible update? (mandatory)

no

Refer to a related PR or issue link (optional)

#3275

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@sre-bot
Copy link
Contributor

sre-bot commented Dec 3, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@ice1000 ice1000 added sig/coprocessor SIG: Coprocessor contribution This PR is from a community contributor. labels Dec 3, 2018
Copy link
Contributor

@ice1000 ice1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ice1000 ice1000 added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 3, 2018
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@breezewish breezewish added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 4, 2018
@zhangjinpeng87 zhangjinpeng87 merged commit 5bb9a3a into tikv:master Dec 4, 2018
@koushiro koushiro deleted the add_week_day branch December 4, 2018 07:48
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/coprocessor SIG: Coprocessor status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants