Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick-2.1] Fix event listener issue #4132

Merged
merged 4 commits into from
Feb 13, 2019

Conversation

DorianZheng
Copy link
Contributor

What have you changed? (mandatory)

Check status of CompactionJobInfo at first.

What are the type of the changes? (mandatory)

  • Bug fix

How has this PR been tested? (mandatory)

CI

Does this PR affect documentation (docs) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

* Check status of CompactionJobInfo

Signed-off-by: DorianZheng <xingzhengde72@gmail.com>

(cherry picked from commit 22957b7)
Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
@siddontang
Copy link
Contributor

CI failed

seem now master and release use different rust version.

/cc @brson @huachaohuang @zhangjinpeng1987

@overvenus overvenus added the type/cherry-pick Type: PR - Cherry pick label Jan 28, 2019
@huachaohuang
Copy link
Contributor

@DorianZheng We should add a release-2.1 branch without Titan related code in pingcap/rust-rocksdb.

@brson
Copy link
Contributor

brson commented Jan 29, 2019

@siddontang yes they are on different versions now. What do you think we should do about it? How long is it between now and the next release?

@siddontang
Copy link
Contributor

Ping @DorianZheng

@overvenus
Copy link
Member

/run-all-tests

@overvenus

This comment has been minimized.

nolouch
nolouch previously approved these changes Feb 13, 2019
Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
@DorianZheng
Copy link
Contributor Author

@overvenus I will create a release-2.1 branch for rust-rocksdb, so never mind the previous CI failed

@DorianZheng
Copy link
Contributor Author

@huachaohuang @zhangjinpeng1987 PTAL

overvenus
overvenus previously approved these changes Feb 13, 2019
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@overvenus
Copy link
Member

/run-integration-tests tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1

Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
Copy link
Contributor

@huachaohuang huachaohuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/util/jemalloc.rs Show resolved Hide resolved
@overvenus overvenus merged commit 831684a into tikv:release-2.1 Feb 13, 2019
@DorianZheng DorianZheng deleted the cherry-pick-release-2.1 branch February 13, 2019 12:10
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants